671121 - Approving-own-revision warning missing for non-English articles

Status: RESOLVED WONTFIX

(support.mozilla.org :: Knowledge Base Software, task)

Description

[Erik Rose [:erik][:erikrose]]

We should do bug 664120 for non-English articles as well.

Comment 1

[Ricky Rosario [:rrosario, :r1cky]]

Kadir specified he wanted it for English in bug 664120. I guess it is common for localizers to approve their own. Kadir?

Comment 2

[Kadir Topal [:atopal]]

Hmm, that's actually a non-trivial decision. On one hand most localization teams are one-man teams, for them this would add an additional step and they are already annoyed by the unnecessary review step. On the other hand: There are real localization teams that could benefit from this. 

In the end this is way more useful for big contributor groups like the English version KB. If it's easy to implement, please implement, but pref it off for locales. If it takes a significant amount of time, let's leave it out.

Comment 3

[Tanay Gavankar [:tgavankar]]

It's not really another step, it's just another sentence on the same confirmation box that they'd have to step through anyway, right? I don't think the way they interact with the page actually changes. One-man teams can easily just ignore the warning.

Comment 4

[Scoobidiver (away)]

How can an English reviewer (https://support.mozilla.com/en-US/groups/reviewers) approve a localized article?
It'd be helpful only if there are a reviewer group of more than one person for the locale.

Comment 5

[James Socol [:jsocol, :james]]

(In reply to comment #4)
> How can an English reviewer
> (https://support.mozilla.com/en-US/groups/reviewers) approve a localized
> article?

Review permissions are not per-locale, at least not yet.

Comment 6

[Scoobidiver (away)]

(In reply to comment #5)
> Review permissions are not per-locale, at least not yet.
I know, but Kadir must create locale-reviewers groups in addition to the global reviewers group if you want to give sense to this change unless you want someone who doesn't speak the language approve a localized article only because it is not allowed to approve its own revision.

Comment 7

[Kadir Topal [:atopal]]

To be clear, this warning is only a recommendation, you can always ignore it if it makes more sense to do so.

But it's also true, that this message would only make sense for localized articles when the text links to the profile of the localization team, not to the general reviewers page.

Comment 8

[Ricky Rosario [:rrosario, :r1cky]]

Is there anything to do here?

Comment 9

[Kadir Topal [:atopal]]

Nope, let's not make it more complicated than necessary for localizers.