Closed Bug 671143 Opened 9 years ago Closed 9 years ago

Rename ValueToNumber to just ToNumber for spec similarity/consistency with other recent To* methods

Categories

(Core :: JavaScript Engine, defect, minor)

defect
Not set
minor

Tracking

()

RESOLVED FIXED
mozilla8

People

(Reporter: Waldo, Assigned: Waldo)

Details

Attachments

(1 file)

Attached patch PatchSplinter Review
cdleary requested this over IRC or IRL awhile back, I think.
Attachment #545552 - Flags: review?(cdleary)
(In reply to comment #0)
> cdleary requested this over IRC or IRL awhile back, I think.

That would be bug 646129 comment 5 IIRC :P
Comment on attachment 545552 [details] [diff] [review]
Patch

Review of attachment 545552 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/jsnum.h
@@ +272,3 @@
>  }
>  
> +/* ES5 9.3 ToNumber.  The number value overwrites the value being converted. */

French spacing makes a certain CTO cry.

::: js/src/jstracer.cpp
@@ +9301,2 @@
>          *tvr.addr() = r;
> +        JS_ALWAYS_TRUE(ToNumber(cx, tvr.value(), &rnum));

Nice catch(es).
Attachment #545552 - Flags: review?(cdleary) → review+
http://hg.mozilla.org/mozilla-central/rev/dcdd255aedf3
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla8
You need to log in before you can comment on or make changes to this bug.