671143 - Rename ValueToNumber to just ToNumber for spec similarity/consistency with other recent To* methods

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Jeff Walden [:Waldo]]

Attachment: Patch

cdleary requested this over IRC or IRL awhile back, I think.

Comment 1

[Luke Wagner [:luke]]

(In reply to comment #0)
> cdleary requested this over IRC or IRL awhile back, I think.

That would be bug 646129 comment 5 IIRC :P

Comment 2

[Chris Leary [:cdleary] (not checking bugmail)]

Comment on attachment 545552 [details] [diff] [review]
Patch

Review of attachment 545552 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/jsnum.h
@@ +272,3 @@
>  }
>  
> +/* ES5 9.3 ToNumber.  The number value overwrites the value being converted. */

French spacing makes a certain CTO cry.

::: js/src/jstracer.cpp
@@ +9301,2 @@
>          *tvr.addr() = r;
> +        JS_ALWAYS_TRUE(ToNumber(cx, tvr.value(), &rnum));

Nice catch(es).

Comment 3

[(no longer active)]

http://hg.mozilla.org/mozilla-central/rev/dcdd255aedf3