The default bug view has changed. See this FAQ.

Rename ValueToNumber to just ToNumber for spec similarity/consistency with other recent To* methods

RESOLVED FIXED in mozilla8

Status

()

Core
JavaScript Engine
--
minor
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: Waldo, Assigned: Waldo)

Tracking

unspecified
mozilla8
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Created attachment 545552 [details] [diff] [review]
Patch

cdleary requested this over IRC or IRL awhile back, I think.
Attachment #545552 - Flags: review?(cdleary)

Comment 1

6 years ago
(In reply to comment #0)
> cdleary requested this over IRC or IRL awhile back, I think.

That would be bug 646129 comment 5 IIRC :P
Comment on attachment 545552 [details] [diff] [review]
Patch

Review of attachment 545552 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/jsnum.h
@@ +272,3 @@
>  }
>  
> +/* ES5 9.3 ToNumber.  The number value overwrites the value being converted. */

French spacing makes a certain CTO cry.

::: js/src/jstracer.cpp
@@ +9301,2 @@
>          *tvr.addr() = r;
> +        JS_ALWAYS_TRUE(ToNumber(cx, tvr.value(), &rnum));

Nice catch(es).
Attachment #545552 - Flags: review?(cdleary) → review+
http://hg.mozilla.org/mozilla-central/rev/dcdd255aedf3
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla8
You need to log in before you can comment on or make changes to this bug.