Last Comment Bug 671143 - Rename ValueToNumber to just ToNumber for spec similarity/consistency with other recent To* methods
: Rename ValueToNumber to just ToNumber for spec similarity/consistency with ot...
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: JavaScript Engine (show other bugs)
: unspecified
: All All
: -- minor (vote)
: mozilla8
Assigned To: Jeff Walden [:Waldo] (remove +bmo to email)
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-07-12 17:47 PDT by Jeff Walden [:Waldo] (remove +bmo to email)
Modified: 2011-07-15 07:06 PDT (History)
2 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Patch (27.11 KB, patch)
2011-07-12 17:47 PDT, Jeff Walden [:Waldo] (remove +bmo to email)
cdleary: review+
Details | Diff | Review

Description Jeff Walden [:Waldo] (remove +bmo to email) 2011-07-12 17:47:08 PDT
Created attachment 545552 [details] [diff] [review]
Patch

cdleary requested this over IRC or IRL awhile back, I think.
Comment 1 Luke Wagner [:luke] 2011-07-12 21:13:46 PDT
(In reply to comment #0)
> cdleary requested this over IRC or IRL awhile back, I think.

That would be bug 646129 comment 5 IIRC :P
Comment 2 Chris Leary [:cdleary] (not checking bugmail) 2011-07-13 13:27:37 PDT
Comment on attachment 545552 [details] [diff] [review]
Patch

Review of attachment 545552 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/jsnum.h
@@ +272,3 @@
>  }
>  
> +/* ES5 9.3 ToNumber.  The number value overwrites the value being converted. */

French spacing makes a certain CTO cry.

::: js/src/jstracer.cpp
@@ +9301,2 @@
>          *tvr.addr() = r;
> +        JS_ALWAYS_TRUE(ToNumber(cx, tvr.value(), &rnum));

Nice catch(es).
Comment 3 :Ehsan Akhgari (out sick) 2011-07-15 07:06:20 PDT
http://hg.mozilla.org/mozilla-central/rev/dcdd255aedf3

Note You need to log in before you can comment on or make changes to this bug.