Closed Bug 671150 Opened 9 years ago Closed 9 years ago

Add memory reporter for the JS PropertyTable

Categories

(Core :: JavaScript Engine, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla8

People

(Reporter: njn, Assigned: njn)

References

(Blocks 1 open bug)

Details

(Whiteboard: [MemShrink:P2][inbound])

Attachments

(1 file)

Bug 563700 says that js::PropertyTable::init() and js::PropertyTable::change() together account for 4.3% in one profile of gmail.
Attached patch patchSplinter Review
Fairly straightforward.
Attachment #547331 - Flags: review?(brendan)
I'm seeing this reduce heap-unclassified by about 2% on normal (for me) browsing.  Not as much as I'd hoped, but better than a kick in the teeth.
Maybe this should go in a different bug, but it would be nice also to count the size of the hashtable holding each shape's children.
(In reply to comment #3)
> Maybe this should go in a different bug, but it would be nice also to count
> the size of the hashtable holding each shape's children.

Just to clarify (for my own benefit):  Shape::kids can point to a KidsHash (which is a typedef for a HashSet, and that's not accounted for.
Comment on attachment 547331 [details] [diff] [review]
patch

entriesSize vs. sizeOf name nit: how about sizeOfEntries instead of entriesSize? More self-consistent, prettier because it avoids the sS conjunction.

r=me with that.

/be
Attachment #547331 - Flags: review?(brendan) → review+
http://hg.mozilla.org/mozilla-central/rev/2d63d7fd35a0
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla8
You need to log in before you can comment on or make changes to this bug.