Add memory reporter for the JS PropertyTable

RESOLVED FIXED in mozilla8

Status

()

Core
JavaScript Engine
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: njn, Assigned: njn)

Tracking

(Blocks: 1 bug)

unspecified
mozilla8
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [MemShrink:P2][inbound])

Attachments

(1 attachment)

(Assignee)

Description

6 years ago
Bug 563700 says that js::PropertyTable::init() and js::PropertyTable::change() together account for 4.3% in one profile of gmail.
(Assignee)

Comment 1

6 years ago
Created attachment 547331 [details] [diff] [review]
patch

Fairly straightforward.
Attachment #547331 - Flags: review?(brendan)
(Assignee)

Comment 2

6 years ago
I'm seeing this reduce heap-unclassified by about 2% on normal (for me) browsing.  Not as much as I'd hoped, but better than a kick in the teeth.
Maybe this should go in a different bug, but it would be nice also to count the size of the hashtable holding each shape's children.
(Assignee)

Comment 4

6 years ago
(In reply to comment #3)
> Maybe this should go in a different bug, but it would be nice also to count
> the size of the hashtable holding each shape's children.

Just to clarify (for my own benefit):  Shape::kids can point to a KidsHash (which is a typedef for a HashSet, and that's not accounted for.
Comment on attachment 547331 [details] [diff] [review]
patch

entriesSize vs. sizeOf name nit: how about sizeOfEntries instead of entriesSize? More self-consistent, prettier because it avoids the sS conjunction.

r=me with that.

/be
Attachment #547331 - Flags: review?(brendan) → review+
(Assignee)

Comment 6

6 years ago
http://hg.mozilla.org/integration/mozilla-inbound/rev/2d63d7fd35a0
Whiteboard: [MemShrink:P2] → [MemShrink:P2][inbound]
http://hg.mozilla.org/mozilla-central/rev/2d63d7fd35a0
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla8
You need to log in before you can comment on or make changes to this bug.