Platform jar.mn files should use "+" to ensure overriding of windows platform bindings

RESOLVED FIXED in mozilla0.9

Status

SeaMonkey
Build Config
P3
normal
RESOLVED FIXED
17 years ago
13 years ago

People

(Reporter: Simon Fraser, Assigned: Kathleen Brade)

Tracking

Trunk
mozilla0.9
All
Mac System 8.5

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

17 years ago
The jar.mn file in xpfe/communicator/ installs the Windows platform overlay files 
by default:

    content/communicator/platformBrowserBindings.xul     (resources/content/win/
platformBrowserBindings.xul) 
    content/communicator/platformEditorBindings.xul      (resources/content/win/
platformEditorBindings.xul) 
    content/communicator/platformGlobalOverlay.xul       (resources/content/win/
platformGlobalOverlay.xul) 

with the expectation that platforms will run jar.mn files in xpfe/communicator/
resources/content/{platform} to override them. But this overriding depends on 
some subtle date comparisons of contains files, and is not guaranteed to work. We 
need to a "+" to the platform jar.mn files to ensure overriding.
(Reporter)

Comment 1

17 years ago
Created attachment 23906 [details] [diff] [review]
Patch

Comment 2

17 years ago
Do we need to do this, or could we just remove these "default" platform files
and require each platform to come up with their own bindings?

Comment 3

17 years ago
That would seem to make much more sense.  Why should a platform that doesn't
specify a platformBindings file get a platformBindings file?  Does something bad
happen if there's no file by that name in the jar file?

Updated

17 years ago
Assignee: cls → waterson
Component: Build Config → XP Miscellany
QA Contact: granrose → brendan

Comment 4

17 years ago
build config doesn't hack those files (trust me, you don't want us touching
that).  Punting to XP Apps since I don't see anything more obvious.
(Reporter)

Comment 5

17 years ago
Are there required bindings in those platform bindings files? Is it bad for other 
platforms to default to the windows bindings?

Comment 6

17 years ago
i think it has things like okcancel which are critical and that we selected the 
windows versions as the default.

i don't know what + syntax does.
(Reporter)

Comment 7

17 years ago
The '+' ensures that this file replaces any existing file at the same locaion in 
the jar file. Without the +, replacement depends on the mod date of the files, 
which is non-predictable.

Comment 8

17 years ago
Are OK/Cancel bindings different on the mac?  If we want some bindings to be the
default, wouldn't it be better to put them in the xp binding set then override
the ones that are different in the mac platform bindings rather than making all
the other platforms copy the bindings into their platform files or pick up the
windows ones?

Comment 9

17 years ago
[s]r=waterson. ship it!
Assignee: waterson → sfraser
Component: XP Miscellany → Build Config

Comment 10

17 years ago
Wait!  Most of the bindings in these XUL files shouldn't be there at all (and
are causing a slew of other bugs on linux due to their overriding of the XBL
platform bindings).  They should have been removed when the XBL bindings were
introduced, but for some reason they weren't.

Kathy and I have been looking at another bug (bug 57078) with a proposed fix of
doing away with most of these files.
(Reporter)

Comment 11

17 years ago
Based on akkana's last comment, -> brade
Assignee: sfraser → brade

Comment 12

17 years ago
setting to moz0.9
Priority: -- → P3
Target Milestone: --- → mozilla0.9
(Assignee)

Comment 13

17 years ago
Checked this fix in; will coordinate with Akkana to update her diffs for #57078.
Status: NEW → RESOLVED
Last Resolved: 17 years ago
Resolution: --- → FIXED
Product: Browser → Seamonkey
You need to log in before you can comment on or make changes to this bug.