Closed Bug 671160 Opened 9 years ago Closed 9 years ago
ASSERTION: Uh, inner window set as event target!
STEPS TO REPRODUCE 1. run mochitest toolkit/components/passwordmgr/test/test_master_password.html ACTUAL RESULTS ###!!! ASSERTION: Uh, inner window set as event target!: '!win || !win->IsInnerWindow()', file content/events/src/nsDOMEvent.cpp, line 878 PLATFORMS AND BUILDS TESTED Bug occurs in a local mozilla-central DEBUG build on Linux x86-64
Can't reproduce. Can you get the stack?
Bz, probably a regression from nsGlobalWindow::DispatchCustomEvent change. We should dispatch the event to outer window. Sorry, I should have noticed the problem when reviewing. We could either just fix this bug, or make event dispatching to handle this case. I think I prefer the first option, since that forces caller to think about whether to use inner or outer window.
Assignee: nobody → bzbarsky
Priority: -- → P1
Whiteboard: [need review]
Attachment #545692 - Flags: review?(Olli.Pettay) → review+
Whiteboard: [need review] → [need landing]
Daniel, please don't nuke my status whiteboard annotations? I actually use them to track what I need to do...
Whiteboard: [sg:high] → [sg:high][need landing]
Whiteboard: [sg:high][need landing] → [sg:high]
Target Milestone: --- → mozilla8
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Is there something QA can do to verify this fix? If not, could you verify the fix Mats?
Whiteboard: [sg:high] → [sg:high][qa?]
The test pass with no assertions in my local debug build on Linux64. Backing out the fix brings it back.
Status: RESOLVED → VERIFIED
Whiteboard: [sg:high][qa?] → [sg:high][qa-]
You need to log in before you can comment on or make changes to this bug.