STEPS TO REPRODUCE 1. run mochitest toolkit/components/passwordmgr/test/test_master_password.html ACTUAL RESULTS ###!!! ASSERTION: Uh, inner window set as event target!: '!win || !win->IsInnerWindow()', file content/events/src/nsDOMEvent.cpp, line 878 PLATFORMS AND BUILDS TESTED Bug occurs in a local mozilla-central DEBUG build on Linux x86-64
Can't reproduce. Can you get the stack?
Bz, probably a regression from nsGlobalWindow::DispatchCustomEvent change. We should dispatch the event to outer window. Sorry, I should have noticed the problem when reviewing. We could either just fix this bug, or make event dispatching to handle this case. I think I prefer the first option, since that forces caller to think about whether to use inner or outer window.
Created attachment 545692 [details] [diff] [review] Fix
Daniel, please don't nuke my status whiteboard annotations? I actually use them to track what I need to do...
Is there something QA can do to verify this fix? If not, could you verify the fix Mats?
The test pass with no assertions in my local debug build on Linux64. Backing out the fix brings it back.