Closed
Bug 671167
Opened 13 years ago
Closed 13 years ago
History shows desktop entries from earlier today as "Yesterday"
Categories
(Firefox for Android Graveyard :: General, defect)
Tracking
(Not tracked)
VERIFIED
FIXED
Firefox 8
People
(Reporter: rnewman, Assigned: wesj)
Details
(Whiteboard: [inbound])
Attachments
(1 file)
753 bytes,
patch
|
mfinkle
:
review+
|
Details | Diff | Splinter Review |
I'm on my phone now, so a drive by report. Visits that I made this afternoon on my Aurora desktop (using Sync, of course) appear in the "Yesterday" section in the history tab of the Fennec navigation bar. Recent Fennec nightly. If I had to guess, I would say it's using UTC for the partitioning, not device time.
Reporter | ||
Comment 1•13 years ago
|
||
Android TZ set to PDT. Cell network time disabled (on Sprint, theirs is shoddy).
Assignee | ||
Comment 2•13 years ago
|
||
Yep. Date.now() returns the time in UTC seconds. Moding it to subtract the number of ms that have occurred today needs to also remove the timezone offset. This does it... a different way.
Assignee: nobody → wjohnston
Attachment #545777 -
Flags: review?(mark.finkle)
Comment 3•13 years ago
|
||
Comment on attachment 545777 [details] [diff] [review] Patch OK. chnage the order to: + today.setHours(0); + today.setMinutes(0); + today.setSeconds(0); to help my OCD ?
Attachment #545777 -
Flags: review?(mark.finkle) → review+
Assignee | ||
Comment 4•13 years ago
|
||
inbound - http://hg.mozilla.org/integration/mozilla-inbound/rev/98729a47464a
Whiteboard: [inbound]
Comment 5•13 years ago
|
||
http://hg.mozilla.org/mozilla-central/rev/98729a47464a
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 8
Comment 6•13 years ago
|
||
Retested bug with: Build id : Mozilla/5.0 (Android;Linux armv7l; rv:9.0a1)Gecko/20110927 Firefox/9.0a1 Fennec /9.0a1 Device: Motorola DROID 2 OS: Android 2.3 and Build id : Mozilla/5.0 (Android;Linux armv7l; rv:8.0a2)Gecko/20110927 Firefox/8.0a2 Fennec /8.0a2 Device: Motorola DROID 2 OS: Android 2.3 History is properly displayed on device for synced accounts from both Firefox Desktop and Aurora Desktop.
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•