Disable use of GL when TFP is not available

RESOLVED FIXED in mozilla8

Status

()

Core
Graphics
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: Rob Bradford, Assigned: mattwoodrow)

Tracking

(Blocks: 1 bug)

Trunk
mozilla8
All
Other
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Reporter)

Description

6 years ago
User Agent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/534.30 (KHTML, like Gecko) Chrome/12.0.742.112 Safari/534.30

Steps to reproduce:

When TFP (texture from pixmap / GLX_EXT_texture_from_pixmap) is unavailable we should not try and provide a GL context.



Expected results:

We should fail initialisation as if GL was not available.

Matt made the following comment on #670645

"I think we should just return PR_FALSE here, performance without this enabled
is significantly reduced over just using X to composite."
(Reporter)

Comment 1

6 years ago
Just returning PR_FALSE as discussed here has the side effect of disabling WebGL...
(Assignee)

Comment 2

6 years ago
Good catch.

Probably the better thing to do is modify the GfxInfoX11/glxtest code to test for the presence of texture_from_pixmap and block the accelerated layers feature.
(Assignee)

Comment 3

6 years ago
Created attachment 549252 [details] [diff] [review]
Block OpenGL when texture_from_pixmap isn't found
Attachment #549252 - Flags: review?(bjacob)
Comment on attachment 549252 [details] [diff] [review]
Block OpenGL when texture_from_pixmap isn't found

r+ with the following comment:

>+    // Disable OpenGL layers when we don't have texture_from_pixmap because it regresses performance. 
>+    if (aFeature == nsIGfxInfo::FEATURE_OPENGL_LAYERS && !mHasTextureFromPixmap) {
>+        *aStatus = nsIGfxInfo::FEATURE_BLOCKED_DRIVER_VERSION;
>+        aSuggestedDriverVersion.AssignLiteral("Anything with EXT_texture_from_pixmap support");
>+        return NS_OK;
>+    }
>+

This is getting injected in about:support in a localized string that says "Try upgrading your driver to version %s or newer" or some such.

So this is going to get very confusing. At least add some kind of brackets to make the sentence easy to parse:

"<Anything with EXT_texture_from_pixmap support>"
Attachment #549252 - Flags: review?(bjacob) → review+
(Assignee)

Comment 5

6 years ago
Created attachment 549618 [details] [diff] [review]
Block OpenGL when texture_from_pixmap isn't found v2

Fixed review comment, carrying forward r=bjacob
Attachment #549252 - Attachment is obsolete: true
Attachment #549618 - Flags: review+
(Assignee)

Updated

6 years ago
Blocks: 594876
(Assignee)

Comment 6

6 years ago
http://hg.mozilla.org/integration/mozilla-inbound/rev/83fe19966844
http://hg.mozilla.org/mozilla-central/rev/83fe19966844
Assignee: nobody → matt.woodrow
Status: UNCONFIRMED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla8
Blocks: 628214
No longer blocks: 628214
You need to log in before you can comment on or make changes to this bug.