671264 - Look for js headers in "include/js/" in addition of "include/$jsname/"

Status: RESOLVED FIXED

(Developer Infrastructure :: Source Code Analysis, defect)

Description

[Mounir Lamouri (:mounir)]

Attachment: Patch v1

TBH, I doubt jsname should be used for something else than the lib name but at least with this patch we are safe in both cases.

Comment 1

[Mike Hommey [:glandium]]

It would probably be better to "simply" rely on pkg-config.

Comment 2

[Mounir Lamouri (:mounir)]

(In reply to comment #1)
> It would probably be better to "simply" rely on pkg-config.

As I understand it, that would require checking if "js", "mozjs" or "mozjs185" is the correct module and then use `pkg-config --cflags mozjs185` and cut it to find the correct include directory. Is that what you had in mind?

Comment 3

[Joshua Cranmer [:jcranmer]]

(In reply to comment #1)
> It would probably be better to "simply" rely on pkg-config.

I don't think that's terribly tenable for people who rely on building spidermonkey from source instead of using distro-provided versions.

Comment 4

[Mounir Lamouri (:mounir)]

Was going trough my old bugs, it's now pushed:
https://hg.mozilla.org/rewriting-and-analysis/dehydra/rev/9a7704207d98

Feel free to open a follow-up to use pkg-config.