The default bug view has changed. See this FAQ.

Replace nsDebugAutoBoolTrueSetter in docshell and AutoBoolSetter in SMIL with AutoRestore

RESOLVED FIXED in mozilla8

Status

()

Core
General
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: bz, Assigned: emorley)

Tracking

Trunk
mozilla8
Points:
---
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Seems like it should be simple to do.

Updated

6 years ago
OS: Mac OS X → All
Hardware: x86 → All
(Assignee)

Comment 1

6 years ago
For reference: (or more so I can close a bunch of tabs)
http://mxr.mozilla.org/mozilla-central/search?string=nsDebugAutoBoolTrueSetter
http://mxr.mozilla.org/mozilla-central/source/docshell/base/nsDocShell.cpp#10881

http://mxr.mozilla.org/mozilla-central/search?string=AutoBoolSetter
http://mxr.mozilla.org/mozilla-central/source/content/smil/nsSMILInstanceTime.cpp#49

http://mxr.mozilla.org/mozilla-central/search?string=AutoRestore
http://mxr.mozilla.org/mozilla-central/source/xpcom/glue/AutoRestore.h#176
Assignee: nobody → bmo
Status: NEW → ASSIGNED
(Assignee)

Comment 2

6 years ago
bz, is this the kind of thing you had in mind?
http://hg.mozilla.org/try/rev/6937e842376c
Yes.  r=me.
(Assignee)

Comment 4

6 years ago
Created attachment 546610 [details] [diff] [review]
Patch v1

Is the patch from comment 2 (no further changes); carrying forward bz's r+

Passed try:
http://dev.philringnalda.com/tbpl/?tree=Try&rev=6ef91a400cf4
Attachment #546610 - Flags: review+
(Assignee)

Updated

6 years ago
Keywords: checkin-needed
http://hg.mozilla.org/integration/mozilla-inbound/rev/bb1f437d4335
Flags: in-testsuite-
Keywords: checkin-needed
Target Milestone: --- → mozilla8
http://hg.mozilla.org/mozilla-central/rev/bb1f437d4335
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.