Closed Bug 671328 Opened 13 years ago Closed 13 years ago

document what mozprocess actually does

Categories

(Testing :: Mozbase, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: k0scist, Unassigned)

References

Details

According to https://github.com/mozautomation/mozmill/blob/master/mozprocess/mozprocess/processhandler.py#L21 :

"""
Represents our view of a subprocess.
It adds a kill() method which allows it to be stopped explicitly.
"""

But help(subprocess.Popen.kill) tells me:

kill(self) unbound subprocess.Popen method
    Kill the process with SIGKILL

We should provide a more thorough picture of what we're actually doing.
Not a thorough end of documentation, but some progress: https://github.com/mozilla/mozbase/commit/6575819da5557ec56347d1ac3b47ef6ebe2818b4

We should document + test the advantages over subprocess.Popen, but will close for now as things are significantly better than when this bug was filed.
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.