671368 - cfx doesn't work on OS X 10.5

Status: RESOLVED FIXED

(Add-on SDK Graveyard :: General, defect)

Description

[Drew Willcoxon :adw]

Attachment: patch

(addon-sdk)11:29:16 ~/test-package$ cfx run -b /Applications/Minefield.app/Contents/MacOS/firefox-bin
Using binary at '/Applications/Minefield.app/Contents/MacOS/firefox-bin'.
dyld: unknown required load command 0x80000022
Traceback (most recent call last):
  File "/Users/adw/addon-sdk/bin/cfx", line 29, in <module>
    cuddlefish.run()
  File "/Users/adw/addon-sdk/python-lib/cuddlefish/__init__.py", line 783, in run
    norun=options.no_run)
  File "/Users/adw/addon-sdk/python-lib/cuddlefish/runner.py", line 323, in run_app
    version_output = check_output([runner.binary, "-v"])
  File "/Users/adw/addon-sdk/python-lib/cuddlefish/runner.py", line 75, in check_output
    raise CalledProcessError(retcode, cmd, output=output)
cuddlefish.runner.CalledProcessError: Command '['/Applications/Minefield.app/Contents/MacOS/firefox-bin', '-v']' returned non-zero exit status -5

Invoking runner.command instead of runner.binary fixes it for me.  Cf. bug 602460.

Comment 1

[Brian Warner [:warner :bwarner]]

Comment on attachment 545714 [details] [diff] [review]
patch

Looks good. Landed in https://github.com/mozilla/addon-sdk/commit/c01f18b14dd4eb72668a7c188943cf40bf72b07b