671372 - Enhance download script to download latest daily build

Status: RESOLVED FIXED

(Mozilla QA Graveyard :: Mozmill Automation, defect)

Description

[Henrik Skupin [:whimboo][⌚️UTC+1] (away from Feb 12th - Feb 22nd)]

Right now if you call the download script for a daily build without specifying the date, it will fail if no build for today is available. We should make the script smarter so we can find the last available build for the specified branch.

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+1] (away from Feb 12th - Feb 22nd)]

Attachment: Patch v1

This adds the feature to download the latest build from a specific branch. Therefore no date has to be specified on the command line. Builds we download get a 'latest-' prefix instead of the date (because we simply don't know the date).

Comment 2

[Geo Mealer [:geo] -- This account is inactive after 2015-07-07]

Comment on attachment 556048 [details] [diff] [review]
Patch v1

Looks good, assuming you tested it across the different build types. r+

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+1] (away from Feb 12th - Feb 22nd)]

(In reply to Geo Mealer [:geo] from comment #2)
> Looks good, assuming you tested it across the different build types. r+

This only applies to daily builds. Releases and candidate builds are not affected by any of those changes. But yes, I have tested it w/ and w/o the usage of dates.

Landed as:
http://hg.mozilla.org/qa/mozmill-automation/rev/db38f172ff1e

Comment 4

[Dave Hunt [:davehunt] [he/him] ⌚BST]

Comment on attachment 556048 [details] [diff] [review]
Patch v1

>      group.add_option('--date',
>                       dest='date',
> -                     default=datetime.date.today().isoformat(),
> +                     default=None,
>                       metavar='DATE',
>                       help='Date of the build, default: today')
>      parser.add_option_group(group)

Shouldn't we update the help message here to indicate that the default is now the latest build rather than the first build from today?

Comment 5

[Henrik Skupin [:whimboo][⌚️UTC+1] (away from Feb 12th - Feb 22nd)]

We should. Just file a bug or patch it yourself. Thanks for spotting it.

Comment 6

[Henrik Skupin [:whimboo][⌚️UTC+1] (away from Feb 12th - Feb 22nd)]

Blush. Had to push a breakage fix for the download script when downloading a build from a specific date. The removal of the slash in the path caused a regression here.

http://hg.mozilla.org/qa/mozmill-automation/rev/9bc888ec52ca