Move windows.js and browser.js to appropriate directories

RESOLVED FIXED

Status

Mozilla QA
Mozmill Tests
RESOLVED FIXED
7 years ago
7 years ago

People

(Reporter: geo, Assigned: whimboo)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [module-refactor])

Attachments

(1 attachment)

After bug 668221 is closed out, the following files should be moved:

lib/ui/windows.js -> lib/api/windows.js
lib/mixins/browser.js -> lib/ui
lib/mixins/browser/* -> lib/ui/browser/*

Comment 1

7 years ago
A Pivotal Tracker story has been created for this Bug: https://www.pivotaltracker.com/story/show/15817989

Comment 2

7 years ago
Henrik Skupin changed story state to started in Pivotal Tracker
(Assignee)

Comment 3

7 years ago
Created attachment 546142 [details] [diff] [review]
Patch v1

Moves all files and updates the require lines to match the new locations of files.
Assignee: nobody → hskupin
Status: NEW → ASSIGNED
Attachment #546142 - Flags: review?(gmealer)
Comment on attachment 546142 [details] [diff] [review]
Patch v1

Assuming all tests ran so we caught any require strings, looks great to me. Thanks for doing this. r+
Attachment #546142 - Flags: review?(gmealer) → review+
(Assignee)

Comment 5

7 years ago
Landed as:
https://github.com/geoelectric/mozmill-api-refactor/commit/25ed85dc932a353c1a79c223765efed8968f9f4e
Status: ASSIGNED → RESOLVED
Last Resolved: 7 years ago
Hardware: x86 → All
Resolution: --- → FIXED

Comment 6

7 years ago
Henrik Skupin changed story state to finished in Pivotal Tracker

Comment 7

7 years ago
Henrik Skupin changed story state to delivered in Pivotal Tracker

Comment 8

7 years ago
Henrik Skupin changed story state to accepted in Pivotal Tracker
You need to log in before you can comment on or make changes to this bug.