Closed Bug 671452 Opened 14 years ago Closed 14 years ago

Move windows.js and browser.js to appropriate directories

Categories

(Mozilla QA Graveyard :: Mozmill Tests, defect)

Product:
Mozilla QA Graveyard
Component:
Mozmill Tests
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: gmealer, Assigned: whimboo)

References

Details

(Whiteboard: [module-refactor])

Attachments

(1 file)

Patch v1
50.70 KB, patch
gmealer
: review+
Details | Diff | Splinter Review
After bug 668221 is closed out, the following files should be moved: lib/ui/windows.js -> lib/api/windows.js lib/mixins/browser.js -> lib/ui lib/mixins/browser/* -> lib/ui/browser/*
A Pivotal Tracker story has been created for this Bug: https://www.pivotaltracker.com/story/show/15817989
Henrik Skupin changed story state to started in Pivotal Tracker
Attached patch Patch v1 — — Splinter Review
Moves all files and updates the require lines to match the new locations of files.
Assignee: nobody → hskupin
Status: NEW → ASSIGNED
Attachment #546142 - Flags: review?(gmealer)
Comment on attachment 546142 [details] [diff] [review] Patch v1 Assuming all tests ran so we caught any require strings, looks great to me. Thanks for doing this. r+
Attachment #546142 - Flags: review?(gmealer) → review+
Landed as: https://github.com/geoelectric/mozmill-api-refactor/commit/25ed85dc932a353c1a79c223765efed8968f9f4e
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Hardware: x86 → All
Resolution: --- → FIXED
Henrik Skupin changed story state to finished in Pivotal Tracker
Henrik Skupin changed story state to delivered in Pivotal Tracker
Henrik Skupin changed story state to accepted in Pivotal Tracker
Product: Mozilla QA → Mozilla QA Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: