Last Comment Bug 671482 - Don't rely on the system principal's name for the system/user chunk split
: Don't rely on the system principal's name for the system/user chunk split
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: JavaScript Engine (show other bugs)
: unspecified
: All All
: -- normal (vote)
: ---
Assigned To: Nicholas Nethercote [:njn]
:
: Jason Orendorff [:jorendorff]
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-07-13 20:57 PDT by Nicholas Nethercote [:njn]
Modified: 2011-07-15 07:08 PDT (History)
6 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
patch 1 (9.11 KB, patch)
2011-07-13 20:57 PDT, Nicholas Nethercote [:njn]
anygregor: review+
Details | Diff | Splinter Review
patch 2 (872 bytes, patch)
2011-07-13 21:00 PDT, Nicholas Nethercote [:njn]
luke: review+
Details | Diff | Splinter Review

Description Nicholas Nethercote [:njn] 2011-07-13 20:57:15 PDT
Created attachment 545820 [details] [diff] [review]
patch 1

This is a spin-off of bug 669123.  With bug 667915 having landed, it's easier to avoid relying on the system principal's name.

This first patch just renames some things, making them clearer.
Comment 1 Nicholas Nethercote [:njn] 2011-07-13 21:00:17 PDT
Created attachment 545821 [details] [diff] [review]
patch 2

This identifies the system principal as the trusted principal.
Comment 2 Gregor Wagner [:gwagner] 2011-07-13 21:04:32 PDT
Comment on attachment 545820 [details] [diff] [review]
patch 1

Review of attachment 545820 [details] [diff] [review]:
-----------------------------------------------------------------

Note You need to log in before you can comment on or make changes to this bug.