671487 - Support an 'alias' for build targets in AUS3

Status: RESOLVED FIXED

(Release Engineering :: General, defect, P2)

Description

[Nick Thomas [:nthomas] (UTC+12)]

Our json blobs currently have duplicated information for the two mac build targets. If we support something like this:
    ...
    "platforms": {
        "Darwin_x86-gcc3-u-i386-x86_64": {
            "alias": "Darwin_x86_64-gcc3-u-i386-x86_64"
        }
        "Darwin_x86_64-gcc3-u-i386-x86_64": {
            "OS_BOUNCER": "osx",
            "OS_FTP": "mac",
            ...

then we avoid paranoia about huge sets of data being different for platforms that should be the same 99% of the time, and retrieve less data from the db.

Comment 1

[Nick Thomas [:nthomas] (UTC+12)]

Attachment: Add alias support to avoid duplication of mac data

This is on top of bug 668345 (both your and my patches) and bug 668348. 

What do you think of the use of variables in expandRelease (relDataPlat & relDataPlatLoc). That's similar to patcher2 in that it keeps references to several 'depths' in the dict/hash, only the functions were so long there it got hard to keep track of.

I'm planning to update generate-json.py for this too but will do that separately.

Comment 2

[Nick Thomas [:nthomas] (UTC+12)]

Attachment: Add alias support to avoid duplication of mac data

Now with infinity% more accurate patch attachment!

Comment 3

[[e-mail] (:bhearsum)]

Comment on attachment 546495 [details] [diff] [review]
Add alias support to avoid duplication of mac data

Review of attachment 546495 [details] [diff] [review]:
-----------------------------------------------------------------

Other than that, looks good to me.

::: AUS.py
@@ +217,5 @@
> +        alias = relData['platforms'][buildTarget].get('alias')
> +        if alias and alias in relData['platforms']:
> +            relDataPlat = relData['platforms'][alias]
> +        else:
> +            relDataPlat = relData['platforms'][buildTarget]

This and part of the identifyRequest hunk both deal with figuring out what the "true" build target is. Can they be factored to a helper?

Comment 4

[Nick Thomas [:nthomas] (UTC+12)]

Comment on attachment 546495 [details] [diff] [review]
Add alias support to avoid duplication of mac data

Yes, sure can. I have a patch in progress which will do that, and clean up the data handling a bunch at the same time, which I'm going to do in bug 673036.

http://hg.mozilla.org/users/nthomas_mozilla.com/aus3-proto/rev/e9afc6895fc8

Still need to fix up generate-json.py here.

Comment 5

[Nick Thomas [:nthomas] (UTC+12)]

We can fix generate-json.py at the time if we end using that for imports.