The default bug view has changed. See this FAQ.

get rid nsIPresShell::gAccessibilityIsActive

RESOLVED FIXED in mozilla8

Status

()

Core
Disability Access APIs
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: surkov, Assigned: surkov)

Tracking

(Blocks: 1 bug, {access})

unspecified
mozilla8
access
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

6 years ago
Created attachment 545860 [details] [diff] [review]
patch

primary nsIPresShell::gAccessibilityIsActive is artifact from old code, nsIPresShell::AccService() can be used instead.

I didn't remove 'a11y-init-or-shutdown' observer notification even it's not used in code, because it can be helpful to listen accessibility instantiation and can be used by extensions currently.
Attachment #545860 - Flags: review?(roc)
(Assignee)

Updated

6 years ago
Blocks: 389800
Comment on attachment 545860 [details] [diff] [review]
patch

Review of attachment 545860 [details] [diff] [review]:
-----------------------------------------------------------------

r+ with that fixed.

::: layout/base/nsPresShell.cpp
@@ +9314,5 @@
>  #ifdef ACCESSIBILITY
> +bool
> +nsIPresShell::IsAccessibilityActive()
> +{
> +  return static_cast<bool>(GetAccService());

GetAccService() != nsnull

Please make this inline in nsIPresShell.h.
Attachment #545860 - Flags: review?(roc) → review+
(Assignee)

Comment 2

6 years ago
(In reply to comment #1)

> > +nsIPresShell::IsAccessibilityActive()
> > +{
> > +  return static_cast<bool>(GetAccService());
> 
> GetAccService() != nsnull

sure

> Please make this inline in nsIPresShell.h.

iirc, previosly I defined AccService() in cpp file because you didn't wanted to include "nsAccessibilityService.h" into nsIPresShell, so either I should use nsIPresShell::AccService() for that or keep it in cpp. If extra call is not good option then keep it in cpp. Does it make sense?
(Assignee)

Comment 3

6 years ago
http://hg.mozilla.org/integration/mozilla-inbound/rev/29322269de12
Whiteboard: [inbound]
(Assignee)

Comment 4

6 years ago
landed: http://hg.mozilla.org/mozilla-central/rev/29322269de12
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Whiteboard: [inbound]
Target Milestone: --- → mozilla8
You need to log in before you can comment on or make changes to this bug.