Last Comment Bug 671504 - get rid nsIPresShell::gAccessibilityIsActive
: get rid nsIPresShell::gAccessibilityIsActive
: access
Product: Core
Classification: Components
Component: Disability Access APIs (show other bugs)
: unspecified
: All All
-- normal (vote)
: mozilla8
Assigned To: alexander :surkov
: alexander :surkov
Depends on:
Blocks: cleana11y
  Show dependency treegraph
Reported: 2011-07-14 01:38 PDT by alexander :surkov
Modified: 2011-07-19 06:18 PDT (History)
0 users
See Also:
Crash Signature:
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---

patch (11.47 KB, patch)
2011-07-14 01:38 PDT, alexander :surkov
roc: review+
Details | Diff | Splinter Review

Description User image alexander :surkov 2011-07-14 01:38:35 PDT
Created attachment 545860 [details] [diff] [review]

primary nsIPresShell::gAccessibilityIsActive is artifact from old code, nsIPresShell::AccService() can be used instead.

I didn't remove 'a11y-init-or-shutdown' observer notification even it's not used in code, because it can be helpful to listen accessibility instantiation and can be used by extensions currently.
Comment 1 User image Robert O'Callahan (:roc) (email my personal email if necessary) 2011-07-14 15:46:39 PDT
Comment on attachment 545860 [details] [diff] [review]

Review of attachment 545860 [details] [diff] [review]:

r+ with that fixed.

::: layout/base/nsPresShell.cpp
@@ +9314,5 @@
> +bool
> +nsIPresShell::IsAccessibilityActive()
> +{
> +  return static_cast<bool>(GetAccService());

GetAccService() != nsnull

Please make this inline in nsIPresShell.h.
Comment 2 User image alexander :surkov 2011-07-14 19:55:45 PDT
(In reply to comment #1)

> > +nsIPresShell::IsAccessibilityActive()
> > +{
> > +  return static_cast<bool>(GetAccService());
> GetAccService() != nsnull


> Please make this inline in nsIPresShell.h.

iirc, previosly I defined AccService() in cpp file because you didn't wanted to include "nsAccessibilityService.h" into nsIPresShell, so either I should use nsIPresShell::AccService() for that or keep it in cpp. If extra call is not good option then keep it in cpp. Does it make sense?
Comment 4 User image alexander :surkov 2011-07-19 06:18:43 PDT

Note You need to log in before you can comment on or make changes to this bug.