671533 - test_DownloadUtils.js fails when system locale doesn't use the dot as a decimal separator

Status: RESOLVED FIXED

(Toolkit :: Downloads API, defect)

Description

[Mike Hommey [:glandium]]

TEST-UNEXPECTED-FAIL | /mnt/_tests/xpcshell/toolkit/mozapps/downloads/tests/unit/test_DownloadUtils.js | A few seconds remaining  2,3 of 2,4 KB (58 bytes/sec) == A few seconds remaining  2.3 of 2.4 KB (58 bytes/sec) - See following stack:
(...)

(This also means that our lack of running tests on non en-US locales may hide subtle problems that our unit tests are supposed to catch but don't)

Comment 1

[Mike Hommey [:glandium]]

Attachment: Fix test_DownloadUtils.js with locales with a different decimal separator

Comment 2

[Ed Lee :Mardak]

Comment on attachment 545890 [details] [diff] [review]
Fix test_DownloadUtils.js with locales with a different decimal separator

Could be useful to add a test for explicitly checking two decimal replacement even though the testStatuses already have strings that have two decimals.

114   testTransferTotal(234, 4924, _("234 bytes of 4.8 KB"));
115   testTransferTotal(94923, 233923, _("92.7 of 228 KB"));
  +   testTransferTotal(4924, 94923, _("4.8 KB of 92.7"));

Comment 3

[Ed Lee :Mardak]

(In reply to comment #2)
>   +   testTransferTotal(4924, 94923, _("4.8 KB of 92.7"));
Er. Should probably be

testTransferTotal(4924, 94923, _("4.8 of 92.7 KB"));

Comment 4

[Mike Hommey [:glandium]]

http://hg.mozilla.org/integration/mozilla-inbound/rev/b5c5e025368d

Comment 5

[(no longer active)]

http://hg.mozilla.org/mozilla-central/rev/b5c5e025368d