671579 - Optimize GzipUtils::mendBrokenLines

Status: RESOLVED FIXED

(Tree Management Graveyard :: TBPL, defect)

Description

[Markus Stange [:mstange]]

Attachment: v1

For logs like mochitest-4, GzipUtils::mendBrokenLines spends way too much time in array_splice. This causes http://tbpl.swatinem.de/php/getParsedLog.php?id=5530496 to time out, for example.

This patch changes mendBrokenLines to use unset instead of array_splice. unset should be O(1), but unlike array_splice it creates holes in the array, so we need to be careful with the indices. The call to array_values at the end renumbers the array.

Comment 1

[Arpad Borsos [:Swatinem]]

Comment on attachment 545933 [details] [diff] [review]
v1

Review of attachment 545933 [details] [diff] [review]:
-----------------------------------------------------------------

Comment 2

[Markus Stange [:mstange]]

http://hg.mozilla.org/users/mstange_themasta.com/tinderboxpushlog/rev/d0797adea397