Closed Bug 671630 Opened 9 years ago Closed 9 years ago

Various cleanups to typed array initialization

Categories

(Core :: JavaScript Engine, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla8

People

(Reporter: Waldo, Assigned: Waldo)

Details

(Whiteboard: [inbound])

Attachments

(4 files)

No description provided.
A nice benefit is that allocation of array buffer slots for ArrayBuffer.prototype now fits naturally into the initialization path, rather than being an afterthought.
Attachment #545976 - Flags: review?(mrbkap)
Comment on attachment 545972 [details] [diff] [review]
Replace INIT_TYPED_ARRAY_CLASS with a templatized method

Review of attachment 545972 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/jstypedarray.cpp
@@ +1772,5 @@
> +{
> +    JSObject *proto = js_InitClass(cx, global, NULL,
> +                         &ArrayType::slowClasses[ArrayType::ACTUAL_TYPE],
> +                         ArrayType::class_constructor, 3,
> +                         ArrayType::jsprops,

These lines look misindented.
Attachment #545972 - Flags: review?(mrbkap) → review+
Attachment #545973 - Flags: review?(mrbkap) → review+
Attachment #545974 - Flags: review?(mrbkap) → review+
Attachment #545976 - Flags: review?(mrbkap) → review+
I dumped the BYTES_PER_ELEMENT patch into a batched-up push (easy enough because it's near-independent of the others here), but the rest of the patches are still waiting for the typed array storage changes to land.

http://hg.mozilla.org/integration/mozilla-inbound/rev/42921f676fd8

So *don't* close this assuming the single inbound-landing fixes this entire bug.  :-)
http://hg.mozilla.org/mozilla-central/rev/42921f676fd8

leaving open per comment 6
Target Milestone: --- → mozilla8
You need to log in before you can comment on or make changes to this bug.