671631 - test_update.js depends on locale configuration

Status: RESOLVED FIXED

(Toolkit :: Add-ons Manager, defect)

Description

[Mike Hommey [:glandium]]

With some particular settings (most notably, intl.locale.matchOS=true and a system locale that is not en-US), I'm getting these kind of errors:
TEST-UNEXPECTED-FAIL | /tmp/build/_tests/xpcshell/toolkit/mozapps/extensions/test/xpcshell/test_update.js | fr-FR == en-US - See following stack:

Comment 1

[Mike Hommey [:glandium]]

Attachment: Don't hardcode en-US in test_update.js

Comment 2

[Dave Townsend [:mossop]]

Did you test this patch? XPIProvider isn't exported from XPIProvider.jsm.

Comment 3

[Mike Hommey [:glandium]]

I did test, but on 5.0

Comment 4

[Mike Hommey [:glandium]]

Gah, it silently fails (silently, as in pass)

Comment 5

[Mike Hommey [:glandium]]

Attachment: Don't hardcode en-US in test_update.js

This one does work, and does what others tests do

Comment 6

[Mike Hommey [:glandium]]

http://hg.mozilla.org/integration/mozilla-inbound/rev/6f01f4a4b7e0

Comment 7

[Marco Bonardo [:mak]]

http://hg.mozilla.org/mozilla-central/rev/6f01f4a4b7e0