Closed Bug 671787 Opened 13 years ago Closed 13 years ago

Remove an unnecessary PORT_Strdup call in secmod_LoadPKCS11Module

Categories

(NSS :: Libraries, defect, P2)

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: wtc, Assigned: wtc)

Details

Attachments

(1 file)

Attached patch Proposed patchSplinter Review
The secmod_LoadPKCS11Module function in pk11load.c calls
PORT_Strdup to duplicate a string for the argument to a
PR_LoadLibrary call.  That PORT_Strdup call is not necessary
because PR_LoadLibrary takes a const char * argument.

The PORT_Strdup call is in rev. 1.1 of pk11load.c, so I don't
know why it's there.
Attachment #546098 - Flags: review?(emaldona)
Attachment #546098 - Flags: review?(emaldona) → review+
Patch checked in on the NSS trunk (NSS 3.13).

Checking in pk11load.c;
/cvsroot/mozilla/security/nss/lib/pk11wrap/pk11load.c,v  <--  pk11load.c
new revision: 1.33; previous revision: 1.32
done
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: