"ASSERTION: unexpected block frame" with text-overflow, overflow, mathml

RESOLVED FIXED in mozilla8

Status

()

Core
Layout
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: Jesse Ruderman, Assigned: mats)

Tracking

(Blocks: 1 bug, {assertion, testcase})

Trunk
mozilla8
assertion, testcase
Points:
---
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(5 attachments, 1 obsolete attachment)

(Reporter)

Description

6 years ago
Created attachment 546100 [details]
testcase

###!!! ASSERTION: unexpected block frame: '!aFrame->GetStyleDisplay()->IsBlockOutside()', file layout/generic/TextOverflow.cpp, line 89
(Reporter)

Comment 1

6 years ago
Created attachment 546101 [details]
stack trace
(Reporter)

Updated

6 years ago
OS: Windows 7 → All
(Assignee)

Updated

6 years ago
Assignee: nobody → matspal
Hardware: x86_64 → All
(Assignee)

Comment 2

6 years ago
Created attachment 546157 [details]
frame dump

The assertion is a false positive.  The frame class is nsMathMLmsupFrame.
(Assignee)

Comment 3

6 years ago
Created attachment 546160 [details] [diff] [review]
fix

Let's not use style data here, since it's ignored by frame construction
in some cases.  Test the actual frame class instead.
Attachment #546160 - Flags: review?(roc)
(Assignee)

Comment 4

6 years ago
Created attachment 546161 [details] [diff] [review]
test
Attachment #546161 - Flags: review?(roc)
(Assignee)

Comment 5

6 years ago
Comment on attachment 546160 [details] [diff] [review]
fix

Hmm, this triggered the assertion for other tests on Try, investigating...
Attachment #546160 - Flags: review?(roc)
(Assignee)

Comment 6

6 years ago
Created attachment 546218 [details] [diff] [review]
fix v2

The assertions came from 
1. display:inline-block  
2. ComboboxControl(select)
so testing both GetAsBlock() and IsBlockOutside() should work.
Attachment #546160 - Attachment is obsolete: true
Attachment #546218 - Flags: review?(roc)
Comment on attachment 546218 [details] [diff] [review]
fix v2

Review of attachment 546218 [details] [diff] [review]:
-----------------------------------------------------------------
Attachment #546218 - Flags: review?(roc) → review+
Comment on attachment 546161 [details] [diff] [review]
test

Review of attachment 546161 [details] [diff] [review]:
-----------------------------------------------------------------
Attachment #546161 - Flags: review?(roc) → review+
(Assignee)

Comment 9

6 years ago
http://hg.mozilla.org/integration/mozilla-inbound/rev/6143573ea16a
http://hg.mozilla.org/integration/mozilla-inbound/rev/b77da7cab114
Flags: in-testsuite+
Whiteboard: [inbound]
Target Milestone: --- → mozilla8
This (along with most things committed on Friday afternoon) was backed out of mozilla-inbound in order to clear up orange.
Whiteboard: [inbound]
(Assignee)

Comment 11

6 years ago
http://hg.mozilla.org/integration/mozilla-inbound/rev/42e4a85bcb2d
http://hg.mozilla.org/integration/mozilla-inbound/rev/7da298066377
Whiteboard: [inbound]
http://hg.mozilla.org/mozilla-central/rev/42e4a85bcb2d
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Whiteboard: [inbound]
Also: http://hg.mozilla.org/mozilla-central/rev/7da298066377
You need to log in before you can comment on or make changes to this bug.