671817 - All l10n assertions have the same message "unknown failure"

Status: VERIFIED FIXED

(Mozilla QA Graveyard :: Mozmill Result Dashboard, defect)

Description

[[:Aleksej]]

Before bug 668763 was fixed, all assertions had no messages, now all messages are “unknown failure”: http://mozmill-crowd.brasstacks.mozilla.com/#/l10n/report/ca2afbf1bd5ce4e8e57d4acd642c2b86

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+1]]

A failure with our new assertion methods looks like:

"fail": {
  "function": "checkDimensions",
  "message": "Node is cut off at the bottom: id: networkTab. Parent node: id: tabsElement",
  "lineNumber": 175,
  "fileName": "file:///tmp/tmpLnR5GZ.mozmill-tests/lib/localization.js"
}

That means there is no exception object included and we can simply access the message and the other information directly.

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+1]]

My fault. Instead of 'exception' we will have 'fail'. I will update all views to match that code.

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Attachment: Patch v1

Just uses the fail property now. A working example you can see here:
http://mozmill-archive.brasstacks.mozilla.com/#/l10n/report/ca2afbf1bd5ce4e8e57d4acd642ca368

Comment 4

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Lets keep this bug for the l10n assertions only. I will file a new one for all the other views.

Comment 5

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Landed as:
https://github.com/whimboo/mozmill-dashboard/commit/69e43008753a48e4096ea2850e105d73e16fee27

Pushed to all dashboard instances.

Comment 6

[[:Aleksej]]

Thanks, verified.