Created attachment 546185 [details] screenshot STR: 1. Start Thunderbird with a fresh profile. 2. Invoke account setup (happens automatically on first run) 3. Type a bad password, and try to create account ACTUAL RESULTS: The text "Username or password invalid" is very hard to read -- it's gray text in a gray-backgrounded dialog, highlighted in black. I have the default Ubuntu 11.04 theme. I don't recall seeing black-highlighted text (or black backgrounds for text) in any other application, so I don't think this is simply a my-gtk-theme-is-busted issue. See attached screenshot.
Which version of Thunderbird are you using?
Sorry, I meant to mention that -- I'm on the latest Earlybird/Aurora version. (grabbed off of http://ftp.mozilla.org/pub/mozilla.org/thunderbird/nightly/latest-earlybird/ last week & have been accepting nightly-ish updates as they're offered) About Earlybird dialog says "7.0a2 (2011-07-15)"
Just got ViewAbout set up, for this additional version info if it's helpful. about:support says: Mozilla/5.0 (X11; Linux x86_64; rv:7.0a2) Gecko/20110715 Thunderbird/7.0a2 about:buildconfig says: Built from http://hg.mozilla.org/releases/mozilla-aurora/rev/1efb6881323c
I get the same black-highlighting issue for errors in the other fields on the New Account Wizard, too. (e.g. typing something that doesn't look like an email address in that field, or providing an email address & password without filling in "Your name" -- both of those trigger a black-highlighted warning message next to the corresponding field)
6 years ago
6 years ago
Created attachment 546302 [details] Color proposal This is because InfoBackground as background is used. IMHO this choice isn't the best under Linux. I've used as a proposal Highlight as background color and HighlightText as text color. The screenshot shows how it looks under all my installed themes.
I recall someone having bad experience with certain (random) themes when using the color HighLight on top of the Window color. According to the color documentation , there is a InfoText to go together with the InfoBackground value, we might be better off using that. 1. https://developer.mozilla.org/en/CSS/color_value#System_Colors
Comment on attachment 546302 [details] Color proposal The bug that was about Highlight was apparently bug 523972, and while it don't mentions Highlight upon Window, I still think we're safer off defining the text as InfoText. This is also what Firefox uses for it's notification bar. Marking as ui-r minus.
Created attachment 547910 [details] [diff] [review] patch This patch gives text the color InfoText and adds the same padding on the end like on the start. This centers the text in the bubble.
Comment on attachment 547910 [details] [diff] [review] patch Tested in Ambiance, Clearlooks and HighContrast and seems to work well!
Comment on attachment 547910 [details] [diff] [review] patch I guess we want this for 7.0 given that's what it was reported against, do we need it for 6.0 as well?
Checked into aurora and beta: http://hg.mozilla.org/releases/comm-aurora/rev/c8a1c83f60a8 http://hg.mozilla.org/releases/comm-beta/rev/d4895ac5afec