Last Comment Bug 671904 - New Account Wizard bad-input warnings are unreadable (gray-on-black) in Ubuntu 11.04 (e.g. "Please enter your name", "Double check this email address", "Username or password invalid")
: New Account Wizard bad-input warnings are unreadable (gray-on-black) in Ubunt...
Product: Thunderbird
Classification: Client Software
Component: Account Manager (show other bugs)
: unspecified
: x86_64 Linux
-- normal (vote)
: Thunderbird 8.0
Assigned To: Richard Marti (:Paenglab)
Depends on:
  Show dependency treegraph
Reported: 2011-07-15 10:15 PDT by Daniel Holbert [:dholbert]
Modified: 2011-08-04 08:19 PDT (History)
4 users (show)
See Also:
Crash Signature:
QA Whiteboard:
Iteration: ---
Points: ---

screenshot (65.27 KB, image/png)
2011-07-15 10:15 PDT, Daniel Holbert [:dholbert]
no flags Details
Color proposal (56.50 KB, image/png)
2011-07-16 04:07 PDT, Richard Marti (:Paenglab)
bugs: ui‑review-
patch (457 bytes, patch)
2011-07-23 02:12 PDT, Richard Marti (:Paenglab)
bugs: review+
standard8: approval‑comm‑aurora+
Details | Diff | Splinter Review

Description User image Daniel Holbert [:dholbert] 2011-07-15 10:15:42 PDT
Created attachment 546185 [details]

 1. Start Thunderbird with a fresh profile.
 2. Invoke account setup (happens automatically on first run)
 3. Type a bad password, and try to create account

ACTUAL RESULTS: The text "Username or password invalid" is very hard to read -- it's gray text in a gray-backgrounded dialog, highlighted in black.

I have the default Ubuntu 11.04 theme. I don't recall seeing black-highlighted text (or black backgrounds for text) in any other application, so I don't think this is simply a my-gtk-theme-is-busted issue.

See attached screenshot.
Comment 1 User image Mark Banner (:standard8) 2011-07-15 10:36:28 PDT
Which version of Thunderbird are you using?
Comment 2 User image Daniel Holbert [:dholbert] 2011-07-15 10:42:19 PDT
Sorry, I meant to mention that -- I'm on the latest Earlybird/Aurora version.  (grabbed off of last week & have been accepting nightly-ish updates as they're offered)

About Earlybird dialog says "7.0a2 (2011-07-15)"
Comment 3 User image Daniel Holbert [:dholbert] 2011-07-15 10:47:33 PDT
Just got ViewAbout set up, for this additional version info if it's helpful.
about:support says:
Mozilla/5.0 (X11; Linux x86_64; rv:7.0a2) Gecko/20110715 Thunderbird/7.0a2

about:buildconfig says:
Built from
Comment 4 User image Daniel Holbert [:dholbert] 2011-07-15 11:01:36 PDT
I get the same black-highlighting issue for errors in the other fields on the New Account Wizard, too. (e.g. typing something that doesn't look like an email address in that field, or providing an email address & password without filling in "Your name" -- both of those trigger a black-highlighted warning message next to the corresponding field)
Comment 5 User image Richard Marti (:Paenglab) 2011-07-16 04:07:13 PDT
Created attachment 546302 [details]
Color proposal

This is because InfoBackground as background is used. IMHO this choice isn't the best under Linux. I've used as a proposal Highlight as background color and HighlightText as text color. The screenshot shows how it looks under all my installed themes.
Comment 6 User image Andreas Nilsson (:andreasn) 2011-07-20 12:56:20 PDT
I recall someone having bad experience with certain (random) themes when using the color HighLight on top of the Window color. According to the color documentation [1], there is a InfoText to go together with the InfoBackground value, we might be better off using that.

Comment 7 User image Andreas Nilsson (:andreasn) 2011-07-21 15:56:05 PDT
Comment on attachment 546302 [details]
Color proposal

The bug that was about Highlight was apparently bug 523972, and while it don't mentions Highlight upon Window, I still think we're safer off defining the text as InfoText. This is also what Firefox uses for it's notification bar. Marking as ui-r minus.
Comment 8 User image Richard Marti (:Paenglab) 2011-07-23 02:12:53 PDT
Created attachment 547910 [details] [diff] [review]

This patch gives text the color InfoText and adds the same padding on the end like on the start. This centers the text in the bubble.
Comment 9 User image Andreas Nilsson (:andreasn) 2011-07-23 09:37:10 PDT
Comment on attachment 547910 [details] [diff] [review]

Tested in Ambiance, Clearlooks and HighContrast and seems to work well!
Comment 10 User image Mark Banner (:standard8) 2011-07-26 06:06:18 PDT
Checked in:
Comment 11 User image Mark Banner (:standard8) 2011-07-26 06:07:43 PDT
Comment on attachment 547910 [details] [diff] [review]

I guess we want this for 7.0 given that's what it was reported against, do we need it for 6.0 as well?

Note You need to log in before you can comment on or make changes to this bug.