671948 - Add ability to make authenticated requests

Status: RESOLVED INCOMPLETE

(Add-on SDK Graveyard :: General, enhancement, P2)

Description

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

It is currently difficult to make authenticated requests with the requests library. There is currently only the option to manually set an Auth header, which is pretty tricky since you need to access Base64 (for Basic) or hashing algorithms (for Digest) and correctly construct the header.

Ideally the request just has a username and password property that you can set.

Comment 1

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Marking anything that potentially looks like a feature request as "enhancement", sorry for the bugspam. :)

Comment 2

[Pawel Borkowski]

It would be great to do that. FF would be than ahead of other competition with support for 3rd parties as AgileBits and their 1Password app.

Comment 3

[Myk Melez [:myk] [@mykmelez]]

Note: after further investigation, I realized that the enhancement described by this bug isn't actually what 1Password needs to implement their desired extension of HTTP auth dialogs.  So I did some research and posted to the AgileBits forum some suggestions for how to implement it:

http://forum.agilebits.com/index.php?/topic/6702-375-support-for-firefox-6/page__p__40572#entry40572

Comment 4

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

(Pushing all open bugs to the --- milestone for the new triage system)

Comment 6

[Wraithan (Chris McDonald) [:wraithan]]

I think it would be beneficial to include a way of doing HTTP Basic Auth in the request module doing something like:

> Request({
>     url: "https://example.com/",
>     auth: "basic"
>     username: "wraithan",
>     password: "ohai",
>     onComplete: function (response) {
>         console.log(response.text);
>     }
> });

or maybe just offering a basic_auth field that one could fill in with "wraithan:ohai".

If this is desired and anyone has a preferred interface or deviations on what I have put forth, I'd gladly implement it.

Comment 7

[Wraithan (Chris McDonald) [:wraithan]]

Could also offer an auth callback for APIs/sites that request auth. Lots of APIs would work with that though not all. So offering both would be good.

Comment 8

[Firefox Bug Husbandry Bot]

https://bugzilla.mozilla.org/show_bug.cgi?id=1399562