671966 - Running Firebug unit tests triggers fatal assertions in the JS engine

Status: RESOLVED WONTFIX

(Core :: JavaScript Engine, defect)

Description

[Jason Orendorff [:jorendorff]]

Attachment: weaken assertions just enough so that the Firebug tests run

To reproduce,
  - run a debug build of the browser
  - create a new profile
  - go to about:config, right-click, New -> Boolean,
    name: extensions.checkCompatibility.nightly
    value: False
  - install http://getfirebug.com/releases/firebug/1.8/firebug-1.8.0b5.xpi
  - install http://getfirebug.com/releases/fbtest/1.8/fbTest-1.8b11.xpi
  - restart
  - attach a debugger to the browser
  - Tools -> Web Developer -> Firebug -> Show Firebug
  - click the Firebug Icon -> Open Test Console
  - click Run All

(Actually, I think just running the DOM tests would be sufficient.)

I don't have a stack anymore, but the basic problem is that JS_GetScopeChain and jsdbgapi.h JS_GetFrameScopeChain expose parentless Block objects which JSD then ends up wrapping for other compartments and exposing to JavaScript.

It's calling JS_WrapValue on the Block object that triggers the assertions.

The JS engine is arguably right to assert, but here's the patch anyway, for anyone who wants to run Firebug's tests.

Comment 1

[vkarande]

Hi,
I would like to work on this bug

so please guide me.

Comment 2

[Benjamin Bouvier [:bbouvier] (inactive)]

Hi vkarande,

Thank you for your interest in contributing to Firefox!

However, I think this bug is a bit outdated; it is almost 5 years old, the latest version of Firebugs is 2.0.16 according to the website, there is some pending effort to integrate Firebug with the devtools [1]. Because of this, I think this bug should be closed as wontfix; if there are any fatal assertions showing up when running the latest test suite of Firebug, then a new bug should be open instead.

But fear not, vkarande, for there are plenty of other bugs to fix in Firefox! See [2], [3] or [4] for more possible ways to help. Cheers!

[1] https://hacks.mozilla.org/2015/10/firebug-devtools-integration/
[2] http://whatcanidoformozilla.org/
[3] https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/Introduction
[4] http://www.joshmatthews.net/bugsahoy/

Comment 3

[vkarande]

I appreciate your feed back.
Thank you