Closed Bug 672102 Opened 9 years ago Closed 8 years ago

toolbarbutton-day-text is hard to read with personas

Categories

(Calendar :: Lightning Only, defect)

x86
All
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: Paenglab, Assigned: Paenglab)

Details

Attachments

(1 file, 1 obsolete file)

With an active personas the toolbarbutton-day-text is hard to read because of the text-shadow.
Attached patch Remove the text-shadow β€” β€” Splinter Review
All I've done is adding a text-shadow: none.
Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #546400 - Flags: review?(bv1578)
You could consider using the -moz-lwtheme css pseudoclasses. I think there was a patch somewhere in Thunderbird land that removed the text shadow in a certain area when personas are applied.
Attached patch Remove the text-shadow (obsolete) β€” β€” Splinter Review
Now with :-moz-lwtheme also when I think it wouldn't hurt, when we have always text-shadow: none ;)
Attachment #546400 - Attachment is obsolete: true
Attachment #546824 - Flags: review?(bv1578)
Attachment #546400 - Flags: review?(bv1578)
Comment on attachment 546824 [details] [diff] [review]
Remove the text-shadow

Since the icon under the text never changes the background color when themes change, the first patch would be fine too (and is simpler as well).

Philipp, there is a particular reason for using the pseudoclass -moz-lwtheme? 

r+
Attachment #546824 - Flags: review?(bv1578) → review+
Oh it was just a suggestion from reading the bug summary. I'm fine with either solution.
Comment on attachment 546400 [details] [diff] [review]
Remove the text-shadow

I'll reactivate the first patch for check-in because he's simpler.

Taking r+ from other patch
Attachment #546400 - Attachment is obsolete: false
Attachment #546400 - Flags: review+
Attachment #546824 - Attachment is obsolete: true
Keywords: checkin-needed
Pushed to comm-central <http://hg.mozilla.org/comm-central/rev/f30c7074a659>
-> FIXED
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → Trunk
This bug was also pushed to comm-beta and comm-aurora, likely during the last merge.
Target Milestone: Trunk → 1.0b6
You need to log in before you can comment on or make changes to this bug.