672286 - Copy xpcshell.ini only if ENABLE_TESTS is set

Status: RESOLVED FIXED

(MailNews Core :: Build Config, defect)

Description

[Takanori MATSUURA]

We should ensure to exist the directory $(MOZDEPTH)/_tests/xpcshell.

In some situation, $(MOZDEPTH)/_tests/xpcshell does not exist now.
ie. --enable-system-hunspell after http://hg.mozilla.org/mozilla-central/rev/8e5f130a6640

So $(MOZDEPTH)/_tests/xpcshell should be prepared prior to copy $(MOZILLA_SRCDIR)/testing/xpcshell/xpcshell.ini to $(MOZDEPTH)/_tests/xpcshell/xpcshell-core.ini.

Comment 1

[Takanori MATSUURA]

Attachment: Ensure to exist $(MOZDEPTH)/_tests/xpcshell

Comment 2

[Justin Wood (:Callek)]

Comment on attachment 546577 [details] [diff] [review]
Ensure to exist $(MOZDEPTH)/_tests/xpcshell

I'm a little confused on how a change for hunspell enable/disable would cause this dir not to exist, also if it doesn't exist why we would want to copy anything to it in the first place (to hack around other issues)...

That said I could just be being dense, so punting review to Mark. ... Mark if this patch also needs to be in suite/ (if it is indeed needed) can we be sure to make that happen?

Comment 3

[Takanori MATSUURA]

Attachment: my mozconfig

c-c:592a6c14182d with m-c:4274ccb37cf6 is successfully build. However c-c:3d95e40b74f2 with m-c:a0372b031aac failed without the patch.

The only change between the builds is the source tarball.
mozconfig is not changed.

According to the build log, c-c:592a6c14182d generates mozilla/_tests/xpcshell/extensions/spellcheck/hunspell/tests/unit/data directory and it's the only process to generate _tests/xpcshell directory. However c-c:3d95e40b74f2 don't generate mozilla/_tests/xpcshell directory during the build.

Comment 4

[Takanori MATSUURA]

Attachment: copy xpcshell.ini only if ENABLE_TESTS is set. And ensure to exist $(MOZDEPTH)/_tests/xpcshell, v2

Now I understand that we copied xpcshell.ini anytime. If --disable-tests is set, we don't need to copy it.

Comment 6

[Takanori MATSUURA]

Attachment: copy xpcshell.ini only if ENABLE_TESTS is set. And ensure to exist $(MOZDEPTH)/_tests/xpcshell - suite part

Comment 7

[Mark Banner (:standard8)]

Checked in: http://hg.mozilla.org/comm-central/rev/6d8318b1709e