Last Comment Bug 672312 - Mini-require should be pulled out of GCLI and made a submodule so it can be shared with Source Map
: Mini-require should be pulled out of GCLI and made a submodule so it can be s...
Status: VERIFIED FIXED
:
Product: Firefox
Classification: Client Software
Component: Developer Tools (show other bugs)
: unspecified
: x86 Mac OS X
: -- normal (vote)
: ---
Assigned To: Joe Walker [:jwalker] (needinfo me or ping on irc)
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-07-18 12:18 PDT by Nick Fitzgerald [:fitzgen] [⏰PDT; UTC-7]
Modified: 2012-01-13 10:37 PST (History)
2 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments

Description Nick Fitzgerald [:fitzgen] [⏰PDT; UTC-7] 2011-07-18 12:18:06 PDT
There are already two copies of mini require just within GCLI, now that I am using a similar build process for Source Map, there are two more copies in the Source Map repo.

I think it would be best to pull this out to its own repository, and we can then include it as a submodule in the GCLI and Source Map repos. Further, I think that there should only be one copy of the mini-require (no difference between the prefix- and normal versions) and then we can use dryice to add the console compat stuff for firefox and the no-globals compat stuff for the browser version.

How does this sound?
Comment 1 Joe Walker [:jwalker] (needinfo me or ping on irc) 2011-08-03 08:50:21 PDT
Totally agree that there should be one authoritative repo.
Totally agree that dryice should be used to manage in-repo copies

Less convinced about using submodules to copy the source. For code that's very nearly 'done', I suspect the cost of using submodules could be greater than the saving of having only one checked in version.

This doesn't have to be an all or nothing. We can do parts 1 and 2, and then 3 if we want, or do it in sourcemap first then gcli later if it proves itself.

Note You need to log in before you can comment on or make changes to this bug.