67234 - perf: make GetTarget() of "<foo>Date?sort=true" return the same target as "<foo>Date"

Status: VERIFIED FIXED

(MailNews Core :: Backend, defect)

Description

[(not reading, please use [e-mail] instead)]

date is our common secondary sort.

the way the xul sort service is written, we'll ask for Date?collation=true, then
Date?sort=true, and then Date.

this trick makes is a tiny bit faster, taking us from three GetTarget() calls to
two.  the big win is making the successful call to GetTarget() faster.

I did this a while ago.  here comes the patch.

ideally, we could make the sort service smarter to know that if ?collation=true
fails for one GetTarget() it will fail for them all.

I'll log a bug to track that.

Comment 1

[(not reading, please use [e-mail] instead)]

Attachment: patch, please review

Comment 2

[David :Bienvenu]

sr=bienvenu

Comment 3

[(not reading, please use [e-mail] instead)]

fixed.  minor performance gain, but I had it in my tree anyways...

Comment 4

[[e-mail] (gone - use [e-mail] instead)]

Note to self: post results of date sorting on the 3 major platforms here.

Comment 5

[(not reading, please use [e-mail] instead)]

this would affect all the sorts.  date sort obviously exercises this
optimization, but all the other sorts do too, since date is a secondary sort on
all the other sorts.

note, it will be a very small optimization, probably not noticable on a machine
with very little memory.

Comment 6

[[e-mail] (gone - use [e-mail] instead)]

And it wasn't noticeable, unfortunately.  But at least sort isn't broken,
marking VERIFIED.  The results are listed on http://www.mozilla.org/mailnews/
under Quality Assurance.