672380 - dragging and dropping a file into text pane of compose window no longer outputs the "file://" URL text text

Status: NEW

(MailNews Core :: Composition, defect)

Description

[office_assistant]

User Agent: Mozilla/5.0 (Windows NT 5.1) AppleWebKit/534.30 (KHTML, like Gecko) Chrome/12.0.742.122 Safari/534.30

Steps to reproduce:

Dragged a document into the text pane of the compose window and dropped it


Actual results:

nothing


Expected results:

The documents "file://" URL should have been outputted as text

Comment 1

[office_assistant]

I was told to create a bug report, after making this support thread:

http://forums.mozillazine.org/viewtopic.php?f=39&t=2253683

Comment 2

[rsx11m]

My best guess is (was, see below) that this is a side effect of bug 609632 now producing data: rather than file: URIs for images dropped into the message body. It checks if the registered file type for that extension (".doc" in your case) is an image type (MS-Word obviously isn't) and inserts it as such if it is.

On the other hand, that code should simply proceed as before if it's not an image, thus I'm a bit at a loss why the behavior has changed for this case.

Comment 3

[office_assistant]

I just upgraded to Thunderbird 6.0 and can confirm that this bug still exists.

Comment 5

[office_assistant]

Just updated to Thunderbird 8.0 and wanted to say that this bug still appears to be present.

Comment 6

[YUKI "Piro" Hiroshi]

I think this is a side effect introduced by changes on the bug 499008.

When I drag and drop a local file on Windows XP SP3, Thunderbird gets the drag data with the types "application/x-moz-file", "text/z-moz-url" and "Files" via the data transfer. (event.dataTransfer.types)

The plaintext editor simply ignores any drag data except "text/plain".
http://mxr.mozilla.org/comm-central/source/mozilla/editor/libeditor/text/nsPlaintextDataTransfer.cpp#163

The HTML editor accepts "application/x-moz-file" but ignores non-image files. (files except PNG, JPEG, GIF or any file with its MIME type "image/*")
And it ignores the type "text/z-moz-url".
http://mxr.mozilla.org/comm-central/source/mozilla/editor/libeditor/html/nsHTMLDataTransfer.cpp#1413

As the result, both plaintext editor and HTML editor don't handle drag and drop of non-image local files. This is clearly regression.

Comment 7

[Ludovic Hirlimann [:Usul]]

(In reply to SHIMODA Hiroshi from comment #6)
> I think this is a side effect introduced by changes on the bug 499008.
> 
> When I drag and drop a local file on Windows XP SP3, Thunderbird gets the
> drag data with the types "application/x-moz-file", "text/z-moz-url" and
> "Files" via the data transfer. (event.dataTransfer.types)
> 
> The plaintext editor simply ignores any drag data except "text/plain".
> http://mxr.mozilla.org/comm-central/source/mozilla/editor/libeditor/text/
> nsPlaintextDataTransfer.cpp#163
> 
> The HTML editor accepts "application/x-moz-file" but ignores non-image
> files. (files except PNG, JPEG, GIF or any file with its MIME type "image/*")
> And it ignores the type "text/z-moz-url".
> http://mxr.mozilla.org/comm-central/source/mozilla/editor/libeditor/html/
> nsHTMLDataTransfer.cpp#1413
> 
> As the result, both plaintext editor and HTML editor don't handle drag and
> drop of non-image local files. This is clearly regression.

How would you feel about creating a patch to fix the issue ?

Comment 8

[Ludovic Hirlimann [:Usul]]

Removing myslef on all the bugs I'm cced on. Please NI me if you need something on MailNews Core bugs from me.