Closed Bug 672460 Opened 9 years ago Closed 9 years ago

Event invitation not sent out when Outlook compatiblity is checked

Categories

(Calendar :: E-mail based Scheduling (iTIP/iMIP), defect)

Lightning 1.0b4
x86_64
Windows 7
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: hb.hbrandt, Assigned: Fallen)

Details

Attachments

(1 file)

User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:5.0) Gecko/20100101 Firefox/5.0
Build ID: 20110615151330

Steps to reproduce:

Created a new calendar entry and added one required attendee.
Upon "Save & Close" the user is asked whether to sent out notification email and one can check a box for support of Outlook 2000 and 2002/XP.
I checked the compatibility box and confirmed the notification with "Ok"


Actual results:

No notification/invitation email reached the attendee.


Expected results:

Attendee should receive an invitation email.

Please note: when the compatibility check is not set the invitation email is sent out. So the problem seems to only occur with the compatible invitation.
OS: Other → Windows 7
Hardware: All → x86_64
Do you get any error console messages?
Yes, there is one error message:

Error: [Exception... "'[JavaScript Error: "setPref is not defined" {file: "file:///D:/Eigene%20Dokumente/Dropbox/Daten/Div/TB5_Portable/ThunderbirdPortable/Data/profile/extensions/%7Be2fda1a4-762b-4020-b5ad-a41df1933103%7D/components/calItipEmailTransport.js" line: 248}]' when calling method: [calIItipTransport::sendItems]"  nsresult: "0x80570021 (NS_ERROR_XPC_JAVASCRIPT_ERROR_WITH_DETAILS)"  location: "JS frame :: resource://calendar/modules/calItipUtils.jsm :: sendMessage :: line 903"  data: yes]
Attached patch Fix - v1 β€” β€” Splinter Review
Perfect! That should be trivial to fix.
Assignee: nobody → philipp
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Attachment #547274 - Flags: review?(matthew.mecca)
Comment on attachment 547274 [details] [diff] [review]
Fix - v1

Change in Makefile seems unrelated to this issue ;). r=mschroeder

We have other instances of calling setPref omitting the 'cal' object which may be also reasonable to fix now:
/calendar/providers/wcap/calWcapSession.js (View Hg log or Hg annotations)
    line 1204 -- setPref("calendar.wcap.confirmed_http_logins", confirmedHttpLogins);
/calendar/providers/gdata/components/calGoogleUtils.js (View Hg log or Hg annotations)
    line 75 -- setPref("calendar.google.calPrefs." + aCalendar.googleCalendarName + "." +
/calendar/providers/gdata/content/gdata-migration.js (View Hg log or Hg annotations)
    line 72 -- setPref("calendar.google.migrate",
/calendar/base/src/calTimezoneService.js (View Hg log or Hg annotations)
    line 360 -- setPref("calendar.timezone.local", this.mDefaultTimezone.tzid);
Attachment #547274 - Flags: review?(matthew.mecca) → review+
Will do, together with a few other random prefixes of cal.
Pushed to comm-central <http://hg.mozilla.org/comm-central/rev/b073f07771ea>
-> FIXED
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → Trunk
Backported to comm-miramar <http://hg.mozilla.org/releases/comm-miramar/rev/2742aa1f2c3f>
Target Milestone: Trunk → 1.0b5
One cal. too much, will push a patch to fix that.
Argh, the additional cal.'s caused so much pain. There is another fix needed, contained in 1.0b5rc3, I will push this to the repositories this evening. If I don't comment on this in the next few days, please do remind me!
If we would have nightly builds new problems could be found soon after checkin instead of having to wait for the next release build.
Agreed, sorry about that. Will fix that asap.

Anyway, here's the revisions:

tree:        comm-central
changeset:   8193:55e650223461
tag:         tip
user:        Philipp Kewisch <mozilla@kewis.ch>
date:        Wed Jul 27 18:35:18 2011 +0200
summary:     Bustage fix for bug 672460 - Event invitation not sent out when Outlook compatiblity is checked.

tree:        comm-miramar
changeset:   7893:32c1026e3c36
tag:         tip
parent:      7890:945e04293069
user:        Philipp Kewisch <mozilla@kewis.ch>
date:        Wed Jul 27 18:35:18 2011 +0200
summary:     Bustage fix for bug 672460 - Event invitation not sent out when Outlook compatiblity is checked.

tree:        comm-miramar
changeset:   7892:845b26bb3c31
branch:      COMM50_20110620_RELBRANCH
user:        Philipp Kewisch <mozilla@kewis.ch>
date:        Wed Jul 27 18:35:18 2011 +0200
summary:     Bustage fix for bug 672460 - Event invitation not sent out when Outlook compatiblity is checked.
You need to log in before you can comment on or make changes to this bug.