672461 - Fails to build with --disable-tests, due to missing _tests/xpcshell

Status: RESOLVED DUPLICATE of bug 672286

(Thunderbird :: Build Config, defect)

Description

[Chris Coulson]

Attachment: Fix build with --disable-tests

Since http://hg.mozilla.org/comm-central/rev/a1b418360875, our nightly builds are failing with this error:

/build/buildd/thunderbird-trunk-8.0~a1~hg20110718r8133+nobinonly/build-tree/mozilla/mozilla/obj-i686-linux-gnu/mozilla/config/nsinstall -t -m 644 /build/buildd/thunderbird-trunk-8.0~a1~hg20110718r8133+nobinonly/build-tree/mozilla/mail/app/blocklist.xml ../../mozilla/dist/bin
cp /build/buildd/thunderbird-trunk-8.0~a1~hg20110718r8133+nobinonly/build-tree/mozilla/mozilla/testing/xpcshell/xpcshell.ini ../../mozilla/_tests/xpcshell/xpcshell-core.ini
cp: cannot create regular file `../../mozilla/_tests/xpcshell/xpcshell-core.ini': No such file or directory
make[6]: *** [libs] Error 1
make[6]: Leaving directory `/build/buildd/thunderbird-trunk-8.0~a1~hg20110718r8133+nobinonly/build-tree/mozilla/mozilla/obj-i686-linux-gnu/mail/app'
make[5]: *** [libs] Error 2
make[5]: Leaving directory `/build/buildd/thunderbird-trunk-8.0~a1~hg20110718r8133+nobinonly/build-tree/mozilla/mozilla/obj-i686-linux-gnu/mail'
make[4]: *** [libs_tier_app] Error 2
make[4]: Leaving directory `/build/buildd/thunderbird-trunk-8.0~a1~hg20110718r8133+nobinonly/build-tree/mozilla/mozilla/obj-i686-linux-gnu'
make[3]: *** [tier_app] Error 2
make[3]: Leaving directory `/build/buildd/thunderbird-trunk-8.0~a1~hg20110718r8133+nobinonly/build-tree/mozilla/mozilla/obj-i686-linux-gnu'
make[2]: *** [default] Error 2
make[2]: Leaving directory `/build/buildd/thunderbird-trunk-8.0~a1~hg20110718r8133+nobinonly/build-tree/mozilla/mozilla/obj-i686-linux-gnu'
make[1]: *** [build] Error 2
make[1]: Leaving directory `/build/buildd/thunderbird-trunk-8.0~a1~hg20110718r8133+nobinonly/build-tree/mozilla'
make: *** [debian/stamp-makefile-build] Error 2
dpkg-buildpackage: error: debian/rules build gave error exit status 2

This is just because _tests/xpcshell doesn't exist yet (we are currently building with --disable-tests).

The attached patch fixes this by deferring the copy until the destination folder has been created (by nsinstall)

Comment 1

[Ludovic Hirlimann [:Usul]]

Isn't that a dup of 672286 ?

Comment 2

[Chris Coulson]

Ah, yes, that looks like the same issue