672492 - Upgrade to jQuery 1.6.2

Status: VERIFIED FIXED

(Webtools Graveyard :: Elmo, defect, P3)

Description

[Peter Bengtsson [:peterbe]]

We're currently relying on a very old version of jQuery (v1.4 in fact). 

Newer versions are faster and work much better with the 'data' attribute which we're relying on heavily with the exhibit plugins. 

Also, being behind on jQuery makes upgrades harder in the future.

Comment 1

[Peter Bengtsson [:peterbe]]

Also note: we currently have ./static/js/jquery.js ./static/js/libs/jquery-1.4.4.min.js

Comment 2

[Peter Bengtsson [:peterbe]]

More note-to-self: Go ahead and try the upgrade, check how the jQuery UI dependent pages behave and consider upgrading jquery UI too.

Comment 3

[Peter Bengtsson [:peterbe]]

Attachment: Upgrades to jQuery 1.6.2

I checked and none of the pages I could find from a monkey-clicking-around broke. Also I checked, the latest jQuery UI version 1.8.4 is based on jQuery 1.3.2 so there's no reason to upgrade jQuery UI.

Comment 4

[Axel Hecht [:Pike]]

Comment on attachment 548416 [details] [diff] [review]
Upgrades to jQuery 1.6.2

Review of attachment 548416 [details] [diff] [review]:
-----------------------------------------------------------------

This doesn't touch js/jquery.js, is that intentional? Seems to me like we'd want to remove that as well?

Comment 5

[Peter Bengtsson [:peterbe]]

(In reply to comment #4)
> Comment on attachment 548416 [details] [diff] [review] [review]
> Upgrades to jQuery 1.6.2
> 
> Review of attachment 548416 [details] [diff] [review] [review]:
> -----------------------------------------------------------------
> 
> This doesn't touch js/jquery.js, is that intentional? Seems to me like we'd
> want to remove that as well?

Uh. I removed it. Lemme check what I did wrong with the git diff

Comment 6

[Peter Bengtsson [:peterbe]]

Attachment: Deletes the two obsolete jquery versions

Two jquery versions removed, one added and base.html now wires jquery-1.6.2-min.js

Comment 7

[Axel Hecht [:Pike]]

Comment on attachment 548743 [details] [diff] [review]
Deletes the two obsolete jquery versions

Review of attachment 548743 [details] [diff] [review]:
-----------------------------------------------------------------

r=me.

Comment 8

[Peter Bengtsson [:peterbe]]

Landed https://github.com/mozilla/elmo/commit/6b2e45cc29eda8aaabff26279a3cf734495b542e

Comment 9

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED on https://l10n-dev-sj.mozilla.org/:

[10:12:26.990] GET https://l10n-dev-sj.mozilla.org/ [HTTP/1.1 200 OK 5212ms]
[10:12:33.584] GET https://l10n-dev-sj.mozilla.org/static/js/libs/jquery-1.6.2.min.js [HTTP/1.1 200 OK 1136ms]