Smooth out nsIAccessible keyboard shortcuts methods

RESOLVED FIXED in mozilla16

Status

()

Core
Disability Access APIs
RESOLVED FIXED
6 years ago
5 years ago

People

(Reporter: surkov, Assigned: Oussama BADR)

Tracking

(Blocks: 1 bug, {access})

unspecified
mozilla16
access
Points:
---
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [good first bug][mentor=surkov.alexander@gmail.com][lang=c++])

Attachments

(2 attachments)

(Reporter)

Description

6 years ago
1) rename keyboardShortcut to getAccessKey(Format)
2) rename defaultKeyBinding to getKeyboardShortcut(Format)
3) remove getKeyBindings

Format is KeyBinding::Format, useful for mochitest testing
(Reporter)

Comment 1

5 years ago
I think we can end up with:

readonly attribute AString accessKey;
readonly attribute AString keyboardShortcut;

For atk format testing we can wait for platform specific testing.

Trevor, good?
(In reply to alexander :surkov from comment #1)
> I think we can end up with:
> 
> readonly attribute AString accessKey;
> readonly attribute AString keyboardShortcut;
> 
> For atk format testing we can wait for platform specific testing.
> 
> Trevor, good?

are we planning to have platform testing for atk soon? if so I think this is fine.
(Reporter)

Comment 3

5 years ago
(In reply to Trevor Saunders (:tbsaunde) from comment #2)
> (In reply to alexander :surkov from comment #1)

> are we planning to have platform testing for atk soon? if so I think this is
> fine.

I hope sooner than somebody adds mochitest for atk format.
(In reply to alexander :surkov from comment #3)
> (In reply to Trevor Saunders (:tbsaunde) from comment #2)
> > (In reply to alexander :surkov from comment #1)
> 
> > are we planning to have platform testing for atk soon? if so I think this is
> > fine.
> 
> I hope sooner than somebody adds mochitest for atk format.

good point :-)
(Reporter)

Comment 5

5 years ago
Oussama, you can take this one if you like.
Whiteboard: [good first bug][mentor=surkov.alexander@gmail.com][lang=c++]
(Assignee)

Comment 6

5 years ago
ok I will check it...thks!
(Assignee)

Comment 7

5 years ago
So i should rename defaultKeyBinding (http://mxr.mozilla.org/mozilla-central/source/accessible/public/nsIAccessible.idl#124) to getAccessKey(Format),
And,
rename keyboardShortcut (http://mxr.mozilla.org/mozilla-central/source/accessible/public/nsIAccessible.idl#118) to getKeyboardShortcut(Format)
and finally,
remove getKeyBindings (http://mxr.mozilla.org/mozilla-central/source/accessible/public/nsIAccessible.idl#132)
and of course, change all their implementations!
right?
(Reporter)

Comment 8

5 years ago
(In reply to Oussama BADR from comment #7)
> So i should rename defaultKeyBinding
> (http://mxr.mozilla.org/mozilla-central/source/accessible/public/
> nsIAccessible.idl#124) to getAccessKey(Format),

readonly attribute AString keyboardShortcut;

(see comment #1)

> And,
> rename keyboardShortcut
> (http://mxr.mozilla.org/mozilla-central/source/accessible/public/
> nsIAccessible.idl#118) to getKeyboardShortcut(Format)

readonly attribute AString accessKey;

> and finally,
> remove getKeyBindings
> (http://mxr.mozilla.org/mozilla-central/source/accessible/public/
> nsIAccessible.idl#132)
> and of course, change all their implementations!

yes
(Assignee)

Comment 9

5 years ago
ok,  thank you to assign me to this bug!
(Reporter)

Updated

5 years ago
Assignee: nobody → oussamabadr
(Assignee)

Comment 10

5 years ago
Created attachment 629583 [details] [diff] [review]
Patch V1 to fix Bug 672514.
Attachment #629583 - Flags: review?(surkov.alexander)
(Reporter)

Comment 11

5 years ago
Comment on attachment 629583 [details] [diff] [review]
Patch V1 to fix Bug 672514.

Review of attachment 629583 [details] [diff] [review]:
-----------------------------------------------------------------

change uuid of nsIAccessible, r=me
Attachment #629583 - Flags: review?(surkov.alexander) → review+
(Assignee)

Comment 12

5 years ago
Created attachment 630867 [details] [diff] [review]
Patch V2 to fix Bug 672514.

Sorry, I have took a time, I was busy this week...!
(Reporter)

Comment 13

5 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/38dfc0d628b4
Flags: in-testsuite+
Target Milestone: --- → mozilla16
https://hg.mozilla.org/mozilla-central/rev/38dfc0d628b4
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.