Last Comment Bug 672514 - Smooth out nsIAccessible keyboard shortcuts methods
: Smooth out nsIAccessible keyboard shortcuts methods
Status: RESOLVED FIXED
[good first bug][mentor=surkov.alexan...
: access
Product: Core
Classification: Components
Component: Disability Access APIs (show other bugs)
: unspecified
: All All
: -- normal (vote)
: mozilla16
Assigned To: Oussama BADR
:
Mentors:
Depends on:
Blocks: cleanxpcoma11y
  Show dependency treegraph
 
Reported: 2011-07-19 08:16 PDT by alexander :surkov
Modified: 2012-06-09 19:32 PDT (History)
4 users (show)
surkov.alexander: in‑testsuite+
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Patch V1 to fix Bug 672514. (6.14 KB, patch)
2012-06-03 03:06 PDT, Oussama BADR
surkov.alexander: review+
Details | Diff | Review
Patch V2 to fix Bug 672514. (6.97 KB, patch)
2012-06-06 23:35 PDT, Oussama BADR
no flags Details | Diff | Review

Description alexander :surkov 2011-07-19 08:16:14 PDT
1) rename keyboardShortcut to getAccessKey(Format)
2) rename defaultKeyBinding to getKeyboardShortcut(Format)
3) remove getKeyBindings

Format is KeyBinding::Format, useful for mochitest testing
Comment 1 alexander :surkov 2012-04-25 00:04:23 PDT
I think we can end up with:

readonly attribute AString accessKey;
readonly attribute AString keyboardShortcut;

For atk format testing we can wait for platform specific testing.

Trevor, good?
Comment 2 Trevor Saunders (:tbsaunde) 2012-04-28 21:47:54 PDT
(In reply to alexander :surkov from comment #1)
> I think we can end up with:
> 
> readonly attribute AString accessKey;
> readonly attribute AString keyboardShortcut;
> 
> For atk format testing we can wait for platform specific testing.
> 
> Trevor, good?

are we planning to have platform testing for atk soon? if so I think this is fine.
Comment 3 alexander :surkov 2012-04-29 19:32:39 PDT
(In reply to Trevor Saunders (:tbsaunde) from comment #2)
> (In reply to alexander :surkov from comment #1)

> are we planning to have platform testing for atk soon? if so I think this is
> fine.

I hope sooner than somebody adds mochitest for atk format.
Comment 4 Trevor Saunders (:tbsaunde) 2012-04-29 19:38:33 PDT
(In reply to alexander :surkov from comment #3)
> (In reply to Trevor Saunders (:tbsaunde) from comment #2)
> > (In reply to alexander :surkov from comment #1)
> 
> > are we planning to have platform testing for atk soon? if so I think this is
> > fine.
> 
> I hope sooner than somebody adds mochitest for atk format.

good point :-)
Comment 5 alexander :surkov 2012-05-26 06:39:36 PDT
Oussama, you can take this one if you like.
Comment 6 Oussama BADR 2012-05-28 05:46:47 PDT
ok I will check it...thks!
Comment 7 Oussama BADR 2012-05-30 09:37:10 PDT
So i should rename defaultKeyBinding (http://mxr.mozilla.org/mozilla-central/source/accessible/public/nsIAccessible.idl#124) to getAccessKey(Format),
And,
rename keyboardShortcut (http://mxr.mozilla.org/mozilla-central/source/accessible/public/nsIAccessible.idl#118) to getKeyboardShortcut(Format)
and finally,
remove getKeyBindings (http://mxr.mozilla.org/mozilla-central/source/accessible/public/nsIAccessible.idl#132)
and of course, change all their implementations!
right?
Comment 8 alexander :surkov 2012-05-30 10:11:54 PDT
(In reply to Oussama BADR from comment #7)
> So i should rename defaultKeyBinding
> (http://mxr.mozilla.org/mozilla-central/source/accessible/public/
> nsIAccessible.idl#124) to getAccessKey(Format),

readonly attribute AString keyboardShortcut;

(see comment #1)

> And,
> rename keyboardShortcut
> (http://mxr.mozilla.org/mozilla-central/source/accessible/public/
> nsIAccessible.idl#118) to getKeyboardShortcut(Format)

readonly attribute AString accessKey;

> and finally,
> remove getKeyBindings
> (http://mxr.mozilla.org/mozilla-central/source/accessible/public/
> nsIAccessible.idl#132)
> and of course, change all their implementations!

yes
Comment 9 Oussama BADR 2012-05-30 10:52:11 PDT
ok,  thank you to assign me to this bug!
Comment 10 Oussama BADR 2012-06-03 03:06:20 PDT
Created attachment 629583 [details] [diff] [review]
Patch V1 to fix Bug 672514.
Comment 11 alexander :surkov 2012-06-03 20:55:48 PDT
Comment on attachment 629583 [details] [diff] [review]
Patch V1 to fix Bug 672514.

Review of attachment 629583 [details] [diff] [review]:
-----------------------------------------------------------------

change uuid of nsIAccessible, r=me
Comment 12 Oussama BADR 2012-06-06 23:35:16 PDT
Created attachment 630867 [details] [diff] [review]
Patch V2 to fix Bug 672514.

Sorry, I have took a time, I was busy this week...!
Comment 14 Ryan VanderMeulen [:RyanVM] 2012-06-09 19:32:49 PDT
https://hg.mozilla.org/mozilla-central/rev/38dfc0d628b4

Note You need to log in before you can comment on or make changes to this bug.