Don't set accessibility.browsewithcaret pref when selecting text in Fennec

VERIFIED FIXED in Firefox 7

Status

Fennec Graveyard
General
VERIFIED FIXED
6 years ago
6 years ago

People

(Reporter: mbrubeck, Assigned: mbrubeck)

Tracking

({verified-aurora})

Trunk
Firefox 7
verified-aurora

Details

Attachments

(1 attachment)

(Assignee)

Description

6 years ago
Created attachment 546818 [details] [diff] [review]
patch

It turns out that browsewithcaret is not needed for selecting text with the mouse.  We can just remove this code.
Attachment #546818 - Flags: review?(mark.finkle)
Comment on attachment 546818 [details] [diff] [review]
patch

Yay!
Attachment #546818 - Flags: review?(mark.finkle) → review+
(Assignee)

Comment 2

6 years ago
http://hg.mozilla.org/mozilla-central/rev/0e48b4287ff2
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
status-firefox8: --- → fixed
Resolution: --- → FIXED
Whiteboard: [has patch]
Target Milestone: --- → Firefox 8
(Assignee)

Comment 3

6 years ago
Comment on attachment 546818 [details] [diff] [review]
patch

Requesting approval-mozilla-aurora.  This fixes issues like bug 671052 that were introduced in Firefox 7 by bug 661388.  The patch is mobile-only and low-risk (it just removes 2 lines of code that turn out to be unnecessary and sometimes harmful).
Attachment #546818 - Flags: approval-mozilla-aurora?
Comment on attachment 546818 [details] [diff] [review]
patch

agreed. mobile-only and low risk.
Attachment #546818 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
(Assignee)

Comment 5

6 years ago
http://hg.mozilla.org/releases/mozilla-aurora/rev/3a5e636515e5
status-firefox7: affected → fixed
Target Milestone: Firefox 8 → Firefox 7
Verified Fixed
Mozilla/5.0 (Android; Linux armv7l; rv:7.0a2) Gecko/20110727 Firefox/7.0a2 Fennec/7.0a2
Status: RESOLVED → VERIFIED
Keywords: verified-aurora
You need to log in before you can comment on or make changes to this bug.