672545 - Create a class-based view cache decorator

Status: RESOLVED FIXED

(Webtools Graveyard :: Elmo, defect, P5)

Description

[Axel Hecht [:Pike]]

In bug 650816, I'm kinda hacking around that fact that the cache decorator doesn't work for view classes.

peterbe would like this to look somewhat like

# urls.py

  url('/foo', FooView.as_view(), name='foo')

# views.py

@cache_control_view(max_age=60)
class FooView(View):
  def get(self)

Comment 1

[Peter Bengtsson [:peterbe]]

Attachment: This is much neater

Actually, it doesn't look like a huge win. However, with this in place we can start adding more decorators later.

Comment 2

[Axel Hecht [:Pike]]

Comment on attachment 632061 [details] [diff] [review]
This is much neater

Review of attachment 632061 [details] [diff] [review]:
-----------------------------------------------------------------

I think there's a left-over import below, r=me with that fixed, or explained.

::: apps/shipping/views/status.py
@@ +4,4 @@
>  
>  '''Views for shipping metrics.
>  '''
> +from collections import defaultdict

Does that belong into this patch?

Comment 3

[[github robot]]

Commit pushed to develop at https://github.com/mozilla/elmo

https://github.com/mozilla/elmo/commit/528920ffaf05acc109d05b42c2b22d9eb6c3476b
bug672545 - class based view decorator utility, r=Pike

Comment 4

[Peter Bengtsson [:peterbe]]

(In reply to Axel Hecht [:Pike] from comment #2)
> Comment on attachment 632061 [details] [diff] [review]
> This is much neater
> 
> Review of attachment 632061 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> I think there's a left-over import below, r=me with that fixed, or explained.
> 
> ::: apps/shipping/views/status.py
> @@ +4,4 @@
> >  
> >  '''Views for shipping metrics.
> >  '''
> > +from collections import defaultdict
> 
> Does that belong into this patch?

Not really. I moved it where it belongs (e.g. before app specific imports) but I also had a bunch of other python imports that I needed for my own development which I later didn't need when I wrapped things up. Lastly, I didn't bother moving it back when I realised there was no real change. Sorry that it confused the patch with noise.