67256 - ReplaceAll with WrapAround should stop replacing before passing initial caret position

Status: VERIFIED FIXED

(Core :: DOM: Editor, defect, P3)

Description

[kinmoz]

Start up a blank composer and type in the following:


foo foo
foo foo


Now place your caret on the first line just after the first "foo".

Bring up the replace dialog (Edit->Replace...) and enter "foo" (without the
quotes) as the string to find and "food" (without the quotes) as the word to
replace with, and make sure the "Wrap Around" checkbox is checked.

Now hit the ReplaceAll button. When it's done, you'll notice that you end up with:


food foodd
food food


You should've ended up with:


food food
food food

Comment 1

[kinmoz]

Attachment: Patch that fixes the bug.

Comment 2

[kinmoz]

The patch I just attatched actually fixes 3 problems.

1. GetCurrentBlockIndex() was returning the wrong block number.
2. We now only call GetCurrentBlockIndex() if we're doing wrap around.
3. Prevents ReplaceAll from going past the initial caret position once we've
wrapped.

Comment 3

[Simon Fraser [no longer active]]

sr=sfraser

Comment 4

[kinmoz]

Just got an r=akkana. Will check in when the tree opens.

Comment 5

[kinmoz]

Fix checked into TRUNK:

    mozilla/editor/txtsvc/src/nsFindAndReplace.cpp  revision 1.2

Comment 6

[kinmoz]

Attachment: Simple test case.

Comment 7

[kinmoz]

Sujay, I just attatched the simple test case I was using to test
Find/Replace/ReplaceAll with.

Try doing a ReplaceAll (forwards and backwards) with WrapAround on with the
caret placed in various positions:

1. At the start of the (first/middle/last) line in the doc
2. At the end of the (first/middle/last)line in the doc
3. in the middle of a word on the (first/middle/last)line in the doc

etc.

Comment 8

[James Baxter]

Verified on 8-28 build