Open
Bug 672659
Opened 14 years ago
Updated 3 years ago
Avoid optimizing large single color images to a solid color
Categories
(Core :: Graphics: ImageLib, defect)
Tracking
()
NEW
People
(Reporter: jrmuizel, Unassigned)
References
Details
Attachments
(1 file)
|
2.53 KB,
patch
|
Details | Diff | Splinter Review |
I don't think it's worth paying this cost on all images.
|
Reporter | |
Comment 1•14 years ago
|
||
|
|
Reporter | |
Comment 2•14 years ago
|
||
This patches causes some reftest failures:
pixel-rounding/image-width-5.html | image comparison (==)
pixel-rounding/image-width-6.html | image comparison (==)
pixel-rounding/image-top-height-5.html | image comparison (==)
pixel-rounding/image-top-height-6.html | image comparison (==)
pixel-rounding/image-left-width-5.html | image comparison (==)
pixel-rounding/image-left-width-6.html | image comparison (==)
pixel-rounding/image-height-top-6.html | image comparison (==)
pixel-rounding/image-width-left-6.html | image comparison (==)
etc.
I suspect that these are real bugs that were hidden by the single color path.
|
||
Comment 3•13 years ago
|
||
I think this patch really is a good thing! We should figure out why we have these test failures.
|
||
Updated•3 years ago
|
Severity: normal → S3
You need to log in
before you can comment on or make changes to this bug.
Description
•