672662 - Provide a chrome registration flag for the platform version

Status: RESOLVED FIXED

(Core :: XPCOM, defect)

Description

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Attachment: Fix - v1

When supporting more then one application, its often more convenient for an extension to specify which platform version their binary component is compatible to. This patch adds a "platformversion" chrome registration flag that acts similar to the appversion flag.

Comment 1

[Benjamin Smedberg]

Comment on attachment 546923 [details] [diff] [review]
Fix - v1

Dave, what do you think of this? This might be a footgun that isn't worth it, but I don't have a strong opinion.

Comment 2

[Dave Townsend [:mossop]]

Comment on attachment 546923 [details] [diff] [review]
Fix - v1

Since we require binary components to be built against a particular platform version I think allowing component selection based on the platform version makes sense, particularly for other apps where the versions don't match.

Comment 3

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Pushed to mozilla-inbound rev e69bb10026f3

Comment 4

[Mounir Lamouri (:mounir)]

Pushed:
http://hg.mozilla.org/mozilla-central/rev/e69bb10026f3

Comment 5

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Thanks! Any chance this could be backported to earlier branches? With this patch it would be possible to support more than two Thunderbird versions at once and the earlier thats possible the better.

Comment 6

[Robert Kaiser]

AFAIK we have documentation of those flags on MDN, so this addition should be mentioned there as well.

Comment 7

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

The documentation contained a slight error, the flag is platformversion not geckoversion. I've corrected this at <https://developer.mozilla.org/en/Chrome_Registration#platformversion>