Closed Bug 672662 Opened 8 years ago Closed 8 years ago

Provide a chrome registration flag for the platform version

Categories

(Core :: XPCOM, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla8

People

(Reporter: Fallen, Assigned: Fallen)

Details

(Keywords: dev-doc-complete)

Attachments

(1 file)

Attached patch Fix - v1Splinter Review
When supporting more then one application, its often more convenient for an extension to specify which platform version their binary component is compatible to. This patch adds a "platformversion" chrome registration flag that acts similar to the appversion flag.
Attachment #546923 - Flags: review?(benjamin)
Comment on attachment 546923 [details] [diff] [review]
Fix - v1

Dave, what do you think of this? This might be a footgun that isn't worth it, but I don't have a strong opinion.
Attachment #546923 - Flags: review?(benjamin) → review?(dtownsend)
Comment on attachment 546923 [details] [diff] [review]
Fix - v1

Since we require binary components to be built against a particular platform version I think allowing component selection based on the platform version makes sense, particularly for other apps where the versions don't match.
Attachment #546923 - Flags: review?(dtownsend) → review+
Pushed to mozilla-inbound rev e69bb10026f3
Whiteboard: [inbound]
Pushed:
http://hg.mozilla.org/mozilla-central/rev/e69bb10026f3
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Whiteboard: [inbound]
Target Milestone: --- → mozilla8
Version: unspecified → Trunk
Thanks! Any chance this could be backported to earlier branches? With this patch it would be possible to support more than two Thunderbird versions at once and the earlier thats possible the better.
AFAIK we have documentation of those flags on MDN, so this addition should be mentioned there as well.
Keywords: dev-doc-needed
The documentation contained a slight error, the flag is platformversion not geckoversion. I've corrected this at <https://developer.mozilla.org/en/Chrome_Registration#platformversion>
Target Milestone: mozilla8 → ---
Version: Trunk → unspecified
Target Milestone: --- → mozilla8
Version: unspecified → Trunk
You need to log in before you can comment on or make changes to this bug.