672691 - get rid of xpcshell test leaks in test_askuser.js

Status: RESOLVED FIXED

(Thunderbird :: Testing Infrastructure, defect)

Description

[David :Bienvenu]

Attachment: proposed fix

extensions/mdn/test_askuser.js reports a bunch of leaks. We should get rid of the noise. Adding the mailshutdown code fixes the leaks. Picking on rkent because I've got a couple more patches for him to review :-)

Comment 1

[David :Bienvenu]

Comment on attachment 546946 [details] [diff] [review]
proposed fix

requesting review from sid0 since I miss him :-)

Comment 2

[Rain [:rain1] (inactive)]

Comment on attachment 546946 [details] [diff] [review]
proposed fix

AFAICT this is the wrong way to use mailShutdown -- you need to add it either to a tail_ file or at the end of the test. I'd prefer a tail_ file so that other tests also benefit.

Comment 3

[David :Bienvenu]

Attachment: fix addressing comments

Comment 4

[Rain [:rain1] (inactive)]

Comment on attachment 546958 [details] [diff] [review]
fix addressing comments

There's an extra line at the end of tail_mdn.js.

Assuming tests pass (I haven't checked), r+.

Comment 5

[David :Bienvenu]

http://hg.mozilla.org/comm-central/rev/de3adcbeac32

Comment 6

[Justin Wood (:Callek)]

(In reply to comment #5)
> http://hg.mozilla.org/comm-central/rev/de3adcbeac32

and followup: http://hg.mozilla.org/comm-central/rev/a159b6b37680

"Someone should teach bienvenu about DONTBUILD" ;-)