Closed Bug 672756 Opened 11 years ago Closed 10 years ago

GENERATE_CACHE in Firefox failed when building it on top of xulrunner


(Toolkit Graveyard :: Build Config, defect)

Not set


(Not tracked)



(Reporter: t.matsuu, Assigned: glandium)




(1 file, 2 obsolete files)

Building firefox is failed when it is built on top of xulrunner.

+++ Failed to get ScriptSecurityManager service, running without principals/bin/sh: line 1: 21824 Segmentation fault      (core dumped) /media/bkup/work/rpmbuild/BUILD/firefox-8.0/mozilla-central/browser/installer/../../dist/bin/ /usr/lib64/xulrunner-sdk-8/bin/xpcshell -g "$PWD" -a "$PWD" -f ../../toolkit/mozapps/installer/precompile_cache.js -e 'populate_startupcache("omni.jar", "");'
make[1]: *** [install] Error 139
To escape this issue, attachment 515715 [details] [diff] [review] in bug 633645 is reverted in the Red Hat version of Firefox 5 RPM package.
Assignee: nobody → mh+mozilla
Attached patch Tentative fix (obsolete) — Splinter Review
(In reply to comment #2)
> Created attachment 547028 [details] [diff] [review] [review]
> Tentative fix

That's a workaround. But I think we should come up with an actual fix. I know how to do it.
Depends on: 655678
Component: XULRunner → Build Config
OS: Linux → All
QA Contact: xulrunner → build-config
Hardware: x86_64 → All
Attachment #547028 - Attachment is obsolete: true
This will need to be refreshed after bug 674352. I hope this doesn't break thunderbird and seamonkey...
Works fine for me.
And attachment 550523 [details] [diff] [review] in bug 674352 is checked into mozilla-inbound.
Comment on attachment 551031 [details] [diff] [review]
Allow to populate startupcache on xulrunner applications built with the SDK

Review of attachment 551031 [details] [diff] [review]:

::: toolkit/mozapps/installer/
@@ +390,5 @@
>  _ABS_RUN_TEST_PROGRAM = $(call core_abspath,$(RUN_TEST_PROGRAM))
>  endif
> +ifdef LIBXUL_SDK

I could probably call this PRECOMPILE_DIR or something. "PROP" isn't very descriptive.
Attachment #551031 - Flags: review?(ted.mielczarek) → review+
Backed out

RUN_TEST_PROGRAM doesn't point to something that exists when in js/src.
Whiteboard: [inbound]
Sometimes, keeping config/ and js/src/config/ in sync hurts :(
Attachment #553126 - Flags: review?(ted.mielczarek)
Attachment #551031 - Attachment is obsolete: true
Comment on attachment 553126 [details] [diff] [review]
Allow to populate startupcache on xulrunner applications built with the SDK

Review of attachment 553126 [details] [diff] [review]:

::: config/
@@ +747,3 @@
>  else
>  ifneq (WINNT,$(OS_ARCH))

You can just use $(LIBXUL_DIST) unconditionally here, since it defaults to $(DIST).
Attachment #553126 - Flags: review?(ted.mielczarek) → review+
As glandium points out, LIBXUL_DIST is not set in js/src, which is the whole reason this is broken. I suggested perhaps in setting LIBXUL_DIST ?= $(DIST)
Closed: 10 years ago
Resolution: --- → FIXED
Whiteboard: [inbound]
Target Milestone: --- → mozilla8
Product: Toolkit → Toolkit Graveyard
You need to log in before you can comment on or make changes to this bug.