672756 - GENERATE_CACHE in Firefox failed when building it on top of xulrunner

Status: RESOLVED FIXED

(Toolkit Graveyard :: Build Config, defect)

Description

[Takanori MATSUURA]

Building firefox is failed when it is built on top of xulrunner.

+++ Failed to get ScriptSecurityManager service, running without principals/bin/sh: line 1: 21824 Segmentation fault      (core dumped) /media/bkup/work/rpmbuild/BUILD/firefox-8.0/mozilla-central/browser/installer/../../dist/bin/run-mozilla.sh /usr/lib64/xulrunner-sdk-8/bin/xpcshell -g "$PWD" -a "$PWD" -f ../../toolkit/mozapps/installer/precompile_cache.js -e 'populate_startupcache("omni.jar", "startupCache.zip");'
make[1]: *** [install] Error 139

Comment 1

[Takanori MATSUURA]

To escape this issue, attachment 515715 [details] [diff] [review] in bug 633645 is reverted in the Red Hat version of Firefox 5 RPM package.

Comment 2

[Takanori MATSUURA]

Attachment: Tentative fix

Comment 3

[Mike Hommey [:glandium]]

(In reply to comment #2)
> Created attachment 547028 [details] [diff] [review] [review]
> Tentative fix

That's a workaround. But I think we should come up with an actual fix. I know how to do it.

Comment 4

[Mike Hommey [:glandium]]

Attachment: Allow to populate startupcache on xulrunner applications built with the SDK

Comment 5

[Mike Hommey [:glandium]]

This will need to be refreshed after bug 674352. I hope this doesn't break thunderbird and seamonkey...

Comment 6

[Takanori MATSUURA]

Works fine for me.
And attachment 550523 [details] [diff] [review] in bug 674352 is checked into mozilla-inbound.

Comment 7

[(not currently active) Ted Mielczarek]

Comment on attachment 551031 [details] [diff] [review]
Allow to populate startupcache on xulrunner applications built with the SDK

Review of attachment 551031 [details] [diff] [review]:
-----------------------------------------------------------------

::: toolkit/mozapps/installer/packager.mk
@@ +390,5 @@
>  _ABS_RUN_TEST_PROGRAM = $(call core_abspath,$(RUN_TEST_PROGRAM))
>  endif
>  
> +ifdef LIBXUL_SDK
> +PRECOMPILE_PROP=XCurProcD

I could probably call this PRECOMPILE_DIR or something. "PROP" isn't very descriptive.

Comment 8

[Mike Hommey [:glandium]]

http://hg.mozilla.org/integration/mozilla-inbound/rev/884efa9dcbf9

Comment 9

[Mike Hommey [:glandium]]

Backed out
http://hg.mozilla.org/integration/mozilla-inbound/rev/22af0a57b683

RUN_TEST_PROGRAM doesn't point to something that exists when in js/src.

Comment 10

[Mike Hommey [:glandium]]

Attachment: Allow to populate startupcache on xulrunner applications built with the SDK

Sometimes, keeping config/config.mk and js/src/config/config.mk in sync hurts :(

Comment 11

[(not currently active) Ted Mielczarek]

Comment on attachment 553126 [details] [diff] [review]
Allow to populate startupcache on xulrunner applications built with the SDK

Review of attachment 553126 [details] [diff] [review]:
-----------------------------------------------------------------

::: config/config.mk
@@ +747,3 @@
>  else
>  ifneq (WINNT,$(OS_ARCH))
> +RUN_TEST_PROGRAM = $(if $(LIBXUL_DIST),$(LIBXUL_DIST),$(DIST))/bin/run-mozilla.sh

You can just use $(LIBXUL_DIST) unconditionally here, since it defaults to $(DIST).

Comment 12

[(not currently active) Ted Mielczarek]

As glandium points out, LIBXUL_DIST is not set in js/src, which is the whole reason this is broken. I suggested perhaps in config.mk setting LIBXUL_DIST ?= $(DIST)

Comment 13

[Mike Hommey [:glandium]]

http://hg.mozilla.org/integration/mozilla-inbound/rev/85b5d609a73c

Comment 14

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

http://hg.mozilla.org/mozilla-central/rev/85b5d609a73c