67284 - PlugletViewMotif.cpp won't compile

Status: VERIFIED INVALID

(Core Graveyard :: Java-Implemented Plugins, defect)

Description

[Marcus Fellinger]

I'm trying to build the /mozilla/java tree. When I run gmake in subdirectory
plugins/src, I get the following error:

PlugletViewMotif.cpp
c++ -DWIDGET_DLL=\"libwidget_gtk.so\" -DGFXWIN_DLL=\"libgfx_gtk.so\"
-I/usr/lib/glib/include -I/usr/X11R6/include -D_REENTRANT  -DOJI_DISABLE
-I/usr/java/jdk1.3.0_01/include/linux -I/usr/java/jdk1.3.0_01/include
-I/usr/local/LessTif/Motif2.0/include  -o PlugletViewMotif.o -c
-DOSTYPE=\"Linux2.2\" -DOJI   -I../../../dist/include -I../../../dist/include  
   -I/usr/X11R6/include   -fPIC  -DWIDGET_DLL=\"libwidget_gtk.so\"
-DGFXWIN_DLL=\"libgfx_gtk.so\" -I/usr/lib/glib/include -I/usr/X11R6/include
-D_REENTRANT  -DOJI_DISABLE -I/usr/java/jdk1.3.0_01/include/linux
-I/usr/java/jdk1.3.0_01/include -I/usr/local/LessTif/Motif2.0/include 
-DMOZILLA_CLIENT -include ../../../config-defs.h
-Wp,-MD,.deps/PlugletViewMotif.pp PlugletViewMotif.cpp
PlugletViewMotif.cpp: In method `PRBool
PlugletViewMotif::SetWindow(nsPluginWindow *)':
PlugletViewMotif.cpp:115: initialization to `int' from `nsPluginPort *' lacks a cast
gmake: *** [PlugletViewMotif.o] Error 1

This also happens if you start gmake in the mozilla/java directory.

I'm using LessTif 0.92.6 to build.

TIA,
Marcus Fellinger
Tomcat Computer GmbH

Comment 1

[Igor Kushnirskiy]

Can you try this:
--
Index: PlugletViewMotif.cpp
===================================================================
RCS file: /cvsroot/mozilla/java/plugins/src/PlugletViewMotif.cpp,v
retrieving revision 1.6
diff -u -r1.6 PlugletViewMotif.cpp
--- PlugletViewMotif.cpp        2000/11/02 23:33:03     1.6
+++ PlugletViewMotif.cpp        2001/02/01 23:26:00
@@ -112,7 +112,7 @@
         return PR_FALSE;
     }
     AwtLock(env);
-    int containerWindowID = win->window;
+    int containerWindowID = (int) win->window;
     printf("containerWindowID=%d WindowID=%d\n",containerWindowID, WindowID);
 #if 0
     if (WindowID == containerWindowID) {

--

Comment 2

[Marcus Fellinger]

After I deleted the java directory and checked the SeaMonkeyBlackwood module out
again, I don't get an error for this line anymore, but just a warning.

win->window is a nsPluginPort*, and under Linux/X11 nsPluginPort is an empty
structure declared in nsPlugindefs.h. I could insert the (int) conversion, but
that might lead to subtly errors on platforms where int and pointers are of
different size.

Comment 3

[Igor Kushnirskiy]

Agreed sizeof(void*) might be bigger than sizeof(int)

containerWindowID is int anyway and that is wrong as you mentioned.
Would you pleas open a new bug about assigning pointers to integers

I am closing this bug as INVALID.

Comment 4

[Alexei V. Mokeev]

VERIFIED