672849 - Create a script for rewriting NS_ENSURE_* to SOMETHING_BETTER_*

Status: NEW

(Core :: XPCOM, defect)

Description

[Steve Fink [:sfink] [:s:]]

Attachment: Rewrite NS_ENSURE* in source tree

The current script handles the majority of cases in the tree, though it doesn't handle reindenting inside macros yet. Example:

#define FUTZ                                   \
  kzort(++x);                                  \
  NS_ENSURE_TRUE(something,NS_ERROR_YOU_SUCK); \
  kabam(x--);

the rewrite expands NS_ENSURE_TRUE into two lines, but doesn't fixup the indent on the 2nd. I can fix that if it looks like this rewrite is going to happen.

It also reports a dozen or so other cases it can't handle that have to be done manually.