672862 - gfxImageSurface incorrectly claims that gfxASurface::Init handles NULL surfaces

Status: RESOLVED INVALID

(Core :: Graphics, defect)

Description

[Josh Matthews [:jdm]]

>92     // cairo_image_surface_create_for_data can return a 'null' surface
>93     // in out of memory conditions. The gfxASurface::Init call checks
>94     // the surface it receives to see if there is an error with the
>95     // surface and handles it appropriately. That is why there is
>96     // no check here.
>97     Init(surface);

>220 void
>221 gfxASurface::Init(cairo_surface_t* surface, PRBool existingSurface)
>222 {
>223     if (cairo_surface_status(surface)) {
>224         // the surface has an error on it
>225         mSurfaceValid = PR_FALSE;
>226         cairo_surface_destroy(surface);
>227         return;
>228     }

>183 cairo_status_t
>184 cairo_surface_status (cairo_surface_t *surface)
>185 {
>186     return surface->status;
>187 }

Comment 1

[Josh Matthews [:jdm]]

I misunderstood the meaning of "'null' surface".