Some accessibility tests scroll window

RESOLVED FIXED in mozilla8

Status

()

Core
Disability Access APIs
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: Neil Deakin (mostly unavailable until September), Assigned: surkov)

Tracking

(Blocks: 1 bug)

Trunk
mozilla8
x86
All
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

This can cause later tests that send events to fail as the element the event is firing on is scrolled out of view.

events/test_aria_menu.html is one such test, others within the events directory seem to also cause this, although I haven't narrowed down which ones.

This issue is affecting some fixes to arrow panels I want to make.
(Assignee)

Comment 1

6 years ago
Do you mean test window (iframe) or main window?

Some accessibility methods do scrolling, maybe this is what we should live with (for example, make tests sensible to scroll position scroll the window too).

Some tests do scrolling (like events/test_aria_menu.html), it's done here to make sure the element can be clicked, otherwise iirc test fails.
(Assignee)

Updated

6 years ago
Blocks: 417472
With the patch in bug 524545 applied, I get a timeout in the test states/test_comboboxes.xul

The main window is scrolling. This has been an issue with other tests (such as bug 667034). One solution, if possible, is to cancel scroll and mousescroll events.
(Assignee)

Comment 3

6 years ago
This test uses DOMNode.scrollIntoView(true) which seems to cause a problem. Anything to be fixed in a11y tests?

Comment 4

6 years ago
For some of the tests, we even need potential scrolling to happen, to test for correct same page anchor jumps, for example. We need a scrolling_start event to be fired so screen readers know that the browser just performed a jump to a same page anchor from a link.
Ah, ok, scrollIntoView scrolls all parent frames as well.

I wonder if other tests have had this issue.

The simplest fix may be to change the tests that use scrollIntoView to scroll back again.
(In reply to comment #5)
> The simplest fix may be to change the tests that use scrollIntoView to
> scroll back again.

What's the simplest way to do that?
You should be able to use window.top.scrollTo(0, 0);
(Assignee)

Comment 8

6 years ago
Created attachment 549121 [details] [diff] [review]
patch

Enn, can you check if it helps please?
Assignee: nobody → surkov.alexander
Status: NEW → ASSIGNED
(Assignee)

Updated

6 years ago
Attachment #549121 - Flags: review?(trev.saunders)
Comment on attachment 549121 [details] [diff] [review]
patch

YEAH, THAT SHOULD FIX THIS INVOKER CAUSING A SCROLL  THAT DOESN'T GET UNDONE
Attachment #549121 - Flags: review?(trev.saunders) → review+
(Assignee)

Comment 10

6 years ago
landed http://hg.mozilla.org/mozilla-central/rev/3a78019c34e5
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
(Assignee)

Updated

6 years ago
Target Milestone: --- → mozilla8
Yes, the tests are ok now.
You need to log in before you can comment on or make changes to this bug.