In the above diff there are changes added to end of overlay.js which aren't shown in the diff bar (its clear rather than green). Other changes in the file are indicated in green. If there are no other changes near the bottom of the existing code then we might be missing potentially dangerous new code. (unfortunately I've had to reject the addon in the url so the link won't work until the xpi is restored - its not working for me right now)
Kris, is this in the code that you wrote?
I think it's in a section with both Andy's code and mine, but I'll take it. I think jQuery's throwing an exception that the event listener is eating, because something strange is happening in the generated DOM. The last diff marker winds up with an empty style attribute after passing a non-empty CSS object to .attr(). I'm going to need to find a way to reproduce this locally. Can someone get me a copy of the two files in the linked diff URL?
-> major, since this can lead to unreviewed code.
Created attachment 547508 [details] [diff] [review] Patch The height of the last marker was turning up NaN. It looks like that line didn't survive my jQuery-ification. It originally used .getBoundingClientRect(), but .offset() obviously doesn't have a .bottom property.
Comment on attachment 547508 [details] [diff] [review] Patch Looks good, thanks Kris.
Reclassifying editor bugs and changing to a new whiteboard flag. Spam, spam, spam, spam...
Whoops. Added wrong bug number