673084 - postflight_all errors when building official mac builds manually

Status: RESOLVED FIXED

(Calendar :: Build Config, defect)

Description

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

I don't have the error at hand right now (mschroeder maybe?), but when building universal builds under mac, we seem to be getting some errors in calendar/lightning/build/universal.mk because some of the variables are not set.

Comment 1

[Martin Schröder [:mschroeder]]

(In reply to comment #0)
> I don't have the error at hand right now (mschroeder maybe?)

/bin/sh: ../obj-thunderbird-lightning-tests-trunk/i386/mozilla/dist/thunderbird/Shredder.app/Contents/MacOS/extensions/{e2fda1a4-762b-4020-b5ad-a41df1933103}/install.rdf_: No such file or directory

Comment 2

[Mark Banner (:standard8)]

Attachment: The fix

The root cause of this seems to be that DISABLE_LIGHTNING_INSTALL=1 is set in the mozconfigs but not in the global environment. The issue here is that we get lightning build with DISABLE_LIGHTNING_INSTALL set, but then when postflight_all comes along, that doesn't get pass the env var and so the flight.mk fails.

The buildbot builds currently get around this by specifying DISABLE_LIGHTNING_INSTALL in the environment.

The code in flight.mk appears to be trying to unify the lightning install.rdf into $(DIST)/universal/<appname>.app/Contents/MacOS/extensions/... however, the problem there is that the rest of the unify code isn't unifying the rest of the lightning extension into that directory.

Rather than trying to fix the flight.mk issue, it appears to be simpler and potentially better to concentrate on getting lightning release builds into the xpi-stage directory, generating build symbols from there (bug 673083).

The only downside to this is that developers building universal binaries of Thunderbird with Lightning, won't get lightning installed into the application directory. I don't think that is a significant issue as it is likely to be rare.

If we find we need it, we can try fixing it properly later.

Comment 3

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Comment on attachment 548568 [details] [diff] [review]
The fix

r=philipp

Comment 4

[Mark Banner (:standard8)]

Checked in: http://hg.mozilla.org/comm-central/rev/4cb88997f292