Moved forum threads should create a redirect

VERIFIED FIXED in 2011-08-02

Status

support.mozilla.org
Forum
VERIFIED FIXED
7 years ago
7 years ago

People

(Reporter: atopal, Assigned: jsocol)

Tracking

unspecified
2011-08-02

Firefox Tracking Flags

(Not tracked)

Details

(Reporter)

Description

7 years ago
Currently moving a forum thread will result in a 404, if that thread is displayed on the dashboard of a user or we sent an email with a link to the thread before it was moved. Instead moving a thread should create a redirect: alternatively, the URL should be independent of the location of a thread.
(Assignee)

Comment 1

7 years ago
This is going to get messy to support this uncommon use case (it's a perf hit for everyone) but it's not hard:

thread = look up thread by ID
forum = look up forum by slug

if forum != thread.forum:
    redirect to thread.get_absolute_url()
Assignee: nobody → james
(Reporter)

Comment 2

7 years ago
Can you elaborate on the messyness and the perf hit? Do you mean in the sense that it will create huge list of redirects that needs to be parsed every time?

Depending on that it might not be worth it.
(Assignee)

Comment 3

7 years ago
Actually, we can probably just compare the slug. It's a very simple lookup right now, and this makes it more complicated. If we compare the slug we won't have to look up a second forum *every* time, just when the requested slug doesn't match.
(Reporter)

Comment 4

7 years ago
Ah, that sounds like a good solution :)
(Assignee)

Comment 5

7 years ago
https://github.com/jsocol/kitsune/commit/b380ebb99
Status: NEW → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
Target Milestone: 2011Q3 → 2011-08-02

Comment 6

7 years ago
This also affects links to KB article discussion forum threads, after the related KB article is renamed.  

Ref: https://support.mozilla.com/en-US/kb/make-firefox-remember-usernames-and-passwords/discuss/1637
(Assignee)

Comment 7

7 years ago
(In reply to comment #6)
> This also affects links to KB article discussion forum threads, after the
> related KB article is renamed.  

kbforums are totally different code: filed bug 673944.
Verified link is updated in notifications and on the user dashboard for the forum post.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.