Closed Bug 673179 Opened 10 years ago Closed 10 years ago
Log Firefox and Sync version at the start of a sync
The log files that are written since bug 610832 no longer contain the Firefox or Sync version number, so we should probably log that at the beginning of a sync.
Had ten minutes to kill.
Assignee: nobody → rnewman
Status: NEW → ASSIGNED
Attachment #547460 - Flags: review?(philipp)
Doesn't log the Firefox version, though...
Comment on attachment 547460 [details] [diff] [review] Trivial patch. v1 I think we should log what's in the User-Agent header: App name, build ID and Weave version. This will determine STORAGE_VERSION already (we have version control, y'know :)). Also, have you run tests? I don't 'remoteVersion' is defined at this scope (I also don't think we need to log it because we already do it elsewhere.)
Attachment #547460 - Flags: review?(philipp) → review-
> I think we should log what's in the User-Agent header: App name, build ID > and Weave version. This will determine STORAGE_VERSION already (we have > version control, y'know :)). Yes, ran out of time to upload my newer patch before running out the door...
This is the patch I meant to attach :)
Attachment #547497 - Flags: review?(philipp) → review+
Pushed: https://hg.mozilla.org/services/services-central/rev/9d2e6f14492c QA steps: * Turn logOnSuccess to true. Restart. * Run two syncs. * View the last two entries in about:sync-log. Verify that something like 1311281228426 Sync.Service DEBUG User-Agent: Firefox/8.0a1 FxSync/184.108.40.20610721134148. appears in each log.
Whiteboard: [fixed in services]
verified on nightly s-c builds of 20110725
Whiteboard: [fixed in services] → [verified in services]
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla8
Component: Firefox Sync: Backend → Sync
Product: Cloud Services → Firefox
You need to log in before you can comment on or make changes to this bug.